Support gitlab subgroups - #51
Open
gjnoonan wants to merge 1 commit into
Open
Conversation
This commit updates `org-sync-gitlab-backend` to allow it to properly parse urls with multiple subgroups. I've replaced the regex that was used, to now use the `url-parse` functions that come with emacs.
Collaborator
|
Can you add some example URLs that show what a URL with subgroups might look like? I imagine it will be easier for the next person coming around, wondering what this function does, to see some example inputs. A proper test case would of course be best but seeing how we have a long way to go there (there are like no tests now) I think adding a comment above the function with a few examples is the second best thing. |
|
@plajjan sure! The git ssh address I'm using is: So in this case the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
org-sync-gitlab-backendto allow it to properly parse urlswith multiple subgroups. I've replaced the regex that was used, to now use the
url-parsefunctions that come with emacs.