Conversation
#10) * Refactor golangci.yml configuration by removing unused linter settings Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Update security.yml to simplify Gosec output and remove unnecessary actions permission Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Refactor golangci-lint configuration and improve code style consistency Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Remove unused prealloc settings from golangci.yml configuration Signed-off-by: dgtalbug <dgtalbug@gmail.com> --------- Signed-off-by: dgtalbug <dgtalbug@gmail.com>
….yml Signed-off-by: dgtalbug <dgtalbug@gmail.com>
…rkflow Signed-off-by: dgtalbug <dgtalbug@gmail.com>
Signed-off-by: dgtalbug <dgtalbug@gmail.com>
Signed-off-by: dgtalbug <dgtalbug@gmail.com>
* Implement state management and history commands with YAML persistence Signed-off-by: dgtalbug <dgtalbug@gmail.com> * feat: establish test infrastructure with initial planning and dependencies Signed-off-by: dgtalbug <dgtalbug@gmail.com> * feat: add YAML state files and enhance storage functionality with tests Signed-off-by: dgtalbug <dgtalbug@gmail.com> --------- Signed-off-by: dgtalbug <dgtalbug@gmail.com>
Signed-off-by: DgtalBug <17087824+dgtalbug@users.noreply.github.com>
Signed-off-by: dgtalbug <dgtalbug@gmail.com>
… output Signed-off-by: dgtalbug <dgtalbug@gmail.com>
#10) * Refactor golangci.yml configuration by removing unused linter settings Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Update security.yml to simplify Gosec output and remove unnecessary actions permission Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Refactor golangci-lint configuration and improve code style consistency Signed-off-by: dgtalbug <dgtalbug@gmail.com> * Remove unused prealloc settings from golangci.yml configuration Signed-off-by: dgtalbug <dgtalbug@gmail.com> --------- Signed-off-by: dgtalbug <dgtalbug@gmail.com>
Signed-off-by: dgtalbug <dgtalbug@gmail.com>
* Implement state management and history commands with YAML persistence Signed-off-by: dgtalbug <dgtalbug@gmail.com> * feat: establish test infrastructure with initial planning and dependencies Signed-off-by: dgtalbug <dgtalbug@gmail.com> * feat: add YAML state files and enhance storage functionality with tests Signed-off-by: dgtalbug <dgtalbug@gmail.com> --------- Signed-off-by: dgtalbug <dgtalbug@gmail.com>
Signed-off-by: dgtalbug <dgtalbug@gmail.com>
… output Signed-off-by: dgtalbug <dgtalbug@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates our security scanning configuration to reduce false positives from the
gosectool by excluding specific rules and tightening the criteria for reporting issues. It also removes now-unnecessary inline linter suppression comments from the codebase, as these are handled globally. The changes affect CI workflows, linter configuration, Makefile scripts, and state management code.Security scanning configuration improvements:
gosecstep in.github/workflows/security.ymlto exclude rules G304, G301, and G306, and to report only high severity and high confidence issues.gosecsection to.golangci.ymlto globally exclude the same rules and set confidence/severity thresholds to high.securitytarget inMakefileto rungosecin lenient mode with the new exclusions and thresholds.Codebase cleanup:
//nolint:goseccomments frompkg/state/history.goandpkg/state/storage.go, since the excluded rules are now handled by linter configuration. [1] [2] [3]