fix(cli): make repair rollback state verifiable - #27
Open
felirami wants to merge 2 commits into
Open
Conversation
added 2 commits
July 27, 2026 13:28
Distinguish unreadable config from empty values, block repairs with unknown starting state, record partial mutations, and roll back every post-change failure. Co-authored-by: Felirami <feli@arcabot.ai> Signed-off-by: Felirami <feli@arcabot.ai>
Co-authored-by: Felirami <feli@arcabot.ai> Signed-off-by: Felirami <feli@arcabot.ai>
felirami
marked this pull request as ready for review
July 27, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous rollback path treated a successful setter exit code as proof that the original state had been restored. A successful no-op setter could therefore leave authentication changed while reporting rollback success. Gateway token generation also needed a boolean-only presence boundary and explicit partial-failure cleanup.
Safety model
Client-authentication usability remains an explicit external OpenClaw semantic because proving it end-to-end would require handling token material.
Validation
Exact reviewed head:
1d9af7dcb7ac1ccc4d256f222ec9128231b72574OPENTUI_LIBC=musl): 91/91 passednpm audit --omit=dev: 0 vulnerabilitiesIndependent review reconstructed tree
8acb6df8345efc670f2e8ebfbc0fce542d1f8fdffrom the immutable Buzz carrier, reproduced the exact tree, ran the full Node suite plus three additional fault probes, and found no blocking or material issues (96% confidence).Attribution
This is Buzz + Felirami work. Operator implemented and verified the repair; Contrarian independently reviewed it and found the original blocking defect, then cleared the corrected exact tree.
Originating Buzz channel:
agent-lab(4144552c-c494-4754-ab7f-c71be5535de6).