This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Italian PDF module and mapping#101
Open
bembe83 wants to merge 3 commits intoarcanistzed:mainfrom
Open
Conversation
Added italian PDF module by Bembe83
Add translate function into the window object to be used across the script/mapping
Owner
|
I don't think it makes sense for this module to be adding to the window object. The translation function should be added within the scope of the module's API. |
arcanistzed
suggested changes
Jun 17, 2025
Comment on lines
+36
to
+50
| window.translate = function(sourceText, sourceLang, targetLang){ | ||
| $.ajaxSetup({ | ||
| async: false | ||
| }); | ||
| var retString = ""; | ||
| if(sourceText) { | ||
| console.log(sourceText); | ||
| var url = "https://translate.googleapis.com/translate_a/single?client=gtx&sl="+ sourceLang + "&tl=" + targetLang + "&dt=t&q=" + encodeURI(sourceText); | ||
| $.getJSON(url, function(data) { | ||
| retString = data[0][0][0]; | ||
| }); | ||
| console.log(retString); | ||
| } | ||
| return retString; | ||
| } |
Owner
There was a problem hiding this comment.
I don't think it makes sense for this module to be adding to the window object. The translation function should be added within the scope of the module's API.
Owner
There was a problem hiding this comment.
game.modules.get("pdf-sheet").api.translate = ...
see https://foundryvtt.wiki/en/development/guides/package-best-practices#module-apis-and-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the italian PDF and adjusted the mapping to match the module.
Added a translate function in the window object to be used in the mapping (as i did for tools, weapons, armor and languages strings)