Run notice handlers in their own threads#46
Open
daurnimator wants to merge 3 commits intoarcapos:masterfrom
Open
Run notice handlers in their own threads#46daurnimator wants to merge 3 commits intoarcapos:masterfrom
daurnimator wants to merge 3 commits intoarcapos:masterfrom
Conversation
- No references in registry to clean up - No longer throw errors across notice processing (only safe functions used outside of pcall) - Won't try and run handlers in dead coroutine (as always run in dedicated coroutine inside a pcall) - Stores coroutine reference in uservalue
This makes repeatedly setting the handlers cheap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues mentioned here: b1bf4a6