Skip to content

ci(ros): drop Rolling from CI matrices#137

Merged
Nauyix merged 1 commit into
mainfrom
ci/remove-ros2-rolling
Jun 4, 2026
Merged

ci(ros): drop Rolling from CI matrices#137
Nauyix merged 1 commit into
mainfrom
ci/remove-ros2-rolling

Conversation

@Nauyix

@Nauyix Nauyix commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Checklist

Please ensure your PR meets the following requirements:

  • Code follows the style guidelines
  • Tests pass locally (make test or make docker-test)
  • Code is formatted (make format)
  • Documentation updated if needed
  • Commit messages follow conventional commits
  • PR description is complete and clear

Summary

This PR removes ROS 2 Rolling from the default CI, E2E, publish, local CI, and Codecov coverage paths. Explicit manual Rolling Docker targets remain available for local reproduction, but aggregate CI entry points now cover Noetic, Humble, and Jazzy only.


Motivation

Rolling is no longer part of the supported CI matrix. Removing it from automated workflows avoids building, testing, publishing, and tracking coverage for a distro that should not gate PRs.


Changes

Modified Files

Added Files

N/A

Deleted Files

N/A


Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (documentation changes only)
  • Refactoring (code improvement without functional changes)
  • Performance improvement (code changes that improve performance)
  • Test changes (adding, modifying, or removing tests)

Impact Analysis

Breaking Changes

None for runtime behavior. CI no longer builds or tests ROS 2 Rolling by default.

Backward Compatibility

Runtime compatibility is unchanged. Manual Rolling Docker targets remain present for explicit local use.


Testing

Test Environment

  • ROS Distribution: N/A, CI configuration-only change
  • OS: local checkout on Linux
  • Build Type: N/A
  • Base/Head: origin/main at 05049646b22b8548ab0801e7979c6618409e818f, head at 6f3c4cf8107230f1de7c4f20c497c4c412407b6d

Test Cases

  • Unit tests pass locally
  • Integration tests pass locally
  • E2E tests pass (if applicable)
  • Manual testing completed

Manual Testing Steps

  1. git fetch origin passed.
  2. git rev-parse origin/main HEAD origin/ci/remove-ros2-rolling confirmed the tested local head matches the pushed branch head.
  3. git diff --check origin/main...HEAD passed.
  4. bash -n scripts/ci-ros-local.sh scripts/ci-e2e-local.sh scripts/docker-test-ros.sh scripts/docker-test-e2e.sh passed.
  5. rg -n "rolling|Rolling|ros2-rolling|ros-rolling|e2e-rolling" .github/workflows codecov.yml scripts/ci-ros-local.sh scripts/ci-e2e-local.sh docker/docker-compose.test.yml docker/README.md returned no matches.

Full remote-equivalent local CI was not run. Specifically, ./scripts/ci-all-local.sh, Docker ROS/E2E jobs, and WS RPC client E2E were not run locally, so this PR is opened as a draft.

Test Coverage

  • New tests added
  • Existing tests updated
  • Coverage maintained or improved

No runtime tests were added because this change only removes Rolling from CI/test configuration paths.


Screenshots / Recordings

N/A


Performance Impact

  • Memory usage: No change
  • CPU usage: No change
  • Recording throughput: No change
  • Lock contention: No change

Documentation


Related Issues

N/A


Additional Notes

The local working tree contains untracked build/coverage artifact directories, but they are not part of the commit or PR.


Reviewers

N/A


Notes for Reviewers

  • Verify the GitHub Actions matrices now cover only Noetic, Humble, and Jazzy.
  • Verify local aggregate CI targets match the new supported CI distro set.
  • Verify explicit manual Rolling Docker targets should remain available.

Checklist for Reviewers

  • Code changes are correct and well-implemented
  • Tests are adequate and pass
  • Documentation is updated and accurate
  • No unintended side effects
  • Performance impact is acceptable
  • Backward compatibility maintained (if applicable)

- Remove Rolling from GitHub Actions ROS build, test, E2E, and publish matrices

- Drop Rolling Codecov flags and local CI default distro lists

- Exclude Rolling from aggregate Docker CI targets while keeping explicit manual targets
@Nauyix Nauyix marked this pull request as ready for review June 4, 2026 11:05
@Nauyix Nauyix merged commit 48fc72b into main Jun 4, 2026
18 checks passed
@Nauyix Nauyix deleted the ci/remove-ros2-rolling branch June 4, 2026 11:05

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant