ci(ros): drop Rolling from CI matrices#137
Merged
Merged
Conversation
- Remove Rolling from GitHub Actions ROS build, test, E2E, and publish matrices - Drop Rolling Codecov flags and local CI default distro lists - Exclude Rolling from aggregate Docker CI targets while keeping explicit manual targets
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure your PR meets the following requirements:
make testormake docker-test)make format)Summary
This PR removes ROS 2 Rolling from the default CI, E2E, publish, local CI, and Codecov coverage paths. Explicit manual Rolling Docker targets remain available for local reproduction, but aggregate CI entry points now cover Noetic, Humble, and Jazzy only.
Motivation
Rolling is no longer part of the supported CI matrix. Removing it from automated workflows avoids building, testing, publishing, and tracking coverage for a distro that should not gate PRs.
Changes
Modified Files
.github/workflows/docker-build.yml- Remove Rolling from the default Docker image build matrix and distro-to-Dockerfile mapping..github/workflows/tests-ros.yml- Remove Rolling from ROS unit/integration test matrix and update matrix comments..github/workflows/e2e-tests.yml- Remove Rolling from E2E test matrix and update matrix comments..github/workflows/publish.yml- Remove Rolling from the ROS package publish matrix..github/workflows/ci.yml- Update CI orchestration comments from four ROS distros to three CI distros.codecov.yml- Removeros-rollingande2e-rollingflags.Makefile- Remove Rolling from aggregate Docker build/test and ROS2 CI targets while keeping explicit Rolling targets.scripts/ci-ros-local.sh- Remove Rolling from local ROS CI default distros and accepted CI distro list.scripts/ci-e2e-local.sh- Remove Rolling from local E2E CI default distros and accepted CI distro list.docker/docker-compose.test.yml- Remove the Rolling test compose service.docker/README.md- Remove Rolling from the documented test image list.Added Files
N/A
Deleted Files
N/A
Type of Change
Impact Analysis
Breaking Changes
None for runtime behavior. CI no longer builds or tests ROS 2 Rolling by default.
Backward Compatibility
Runtime compatibility is unchanged. Manual Rolling Docker targets remain present for explicit local use.
Testing
Test Environment
origin/mainat05049646b22b8548ab0801e7979c6618409e818f, head at6f3c4cf8107230f1de7c4f20c497c4c412407b6dTest Cases
Manual Testing Steps
git fetch originpassed.git rev-parse origin/main HEAD origin/ci/remove-ros2-rollingconfirmed the tested local head matches the pushed branch head.git diff --check origin/main...HEADpassed.bash -n scripts/ci-ros-local.sh scripts/ci-e2e-local.sh scripts/docker-test-ros.sh scripts/docker-test-e2e.shpassed.rg -n "rolling|Rolling|ros2-rolling|ros-rolling|e2e-rolling" .github/workflows codecov.yml scripts/ci-ros-local.sh scripts/ci-e2e-local.sh docker/docker-compose.test.yml docker/README.mdreturned no matches.Full remote-equivalent local CI was not run. Specifically,
./scripts/ci-all-local.sh, Docker ROS/E2E jobs, and WS RPC client E2E were not run locally, so this PR is opened as a draft.Test Coverage
No runtime tests were added because this change only removes Rolling from CI/test configuration paths.
Screenshots / Recordings
N/A
Performance Impact
Documentation
Related Issues
N/A
Additional Notes
The local working tree contains untracked build/coverage artifact directories, but they are not part of the commit or PR.
Reviewers
N/A
Notes for Reviewers
Checklist for Reviewers