fix(agent): store managed process logs under tmp#140
Merged
Conversation
- Move default managed-process stdout/stderr capture to /tmp/axon-agent/logs - Preserve explicit stdout_log and stderr_log overrides from profile YAML - Document the transient log location and cover the default transfer path This keeps one-shot robot_startup, recorder, and transfer logs out of the persistent agent state directory so they do not accumulate there over time.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure your PR meets the following requirements:
make testormake docker-test)make format)Summary
This PR moves the default stdout/stderr capture files for agent-managed processes into
/tmp/axon-agent/logs. Explicitstdout_logandstderr_logprofile overrides continue to work as before.Motivation
robot_startup,recorder, andtransfercan produce large stdout/stderr logs./tmpwhile preserving configured log paths for deployments that need persistence.Changes
Modified Files
apps/axon_agent/src/process_manager.cpp- Change the default managed-process log directory fromstate_dir/logsto/tmp/axon-agent/logs.apps/axon_agent/test/test_agent_service.cpp- Add coverage for the default transfer stdout/stderr paths.docs/designs/axon-agent-design.md- Document the new transient default log location.packaging/deb/agent/default/axon-agent- Update the default config comments to describe where managed-process logs are written.Added Files
N/A
Deleted Files
N/A
Type of Change
Impact Analysis
Breaking Changes
None expected. Profiles that explicitly configure
stdout_logorstderr_logkeep the existing configured path behavior.Backward Compatibility
The default path for unmanaged stdout/stderr capture changes from the agent state directory to
/tmp/axon-agent/logs. Agent APIs still report the effective log path in process state, andread_logcontinues to read from that path.Testing
Test Environment
apps/axon_agentbuildTest Cases
Full local CI was skipped at user request for this small agent/default-path change. Before committing this same diff, focused local validation was run successfully with:
cmake -S apps/axon_agent -B build-codex-agent -DAXON_AGENT_BUILD_TESTS=ON -DAXON_REPO_ROOT=/home/liuxy/ab_ws/axon cmake --build build-codex-agent --target test_agent_service test_process_manager ctest --test-dir build-codex-agent --output-on-failure -R 'test_agent_service|test_process_manager'Manual Testing Steps
N/A
Test Coverage
Screenshots / Recordings
N/A
Performance Impact
Documentation
Related Issues
Additional Notes
N/A
Reviewers
N/A
Notes for Reviewers
/tmp/axon-agent/logsis the right default location for transient managed-process stdout/stderr capture.stdout_logandstderr_logprofile settings.Checklist for Reviewers