Fix initial website hosting tx when tx already exist#116
Open
MayDaReal wants to merge 3 commits intoarchethic-foundation:mainfrom
Open
Fix initial website hosting tx when tx already exist#116MayDaReal wants to merge 3 commits intoarchethic-foundation:mainfrom
MayDaReal wants to merge 3 commits intoarchethic-foundation:mainfrom
Conversation
…saction chain already used to something else
Author
|
Unfortunately, it seems the fetchLastRefTx function only manages transactions sent from the sender to the receiver address. This means that if you host a website on a keychain and make a transaction from this dedicated keychain to another address, the code suggested in this PR doesn't work as expected. Therefore, the fetchLastRefTx function should manage only transactions of type "hosting" and ignore all others. So, I managed this type of request with GraphQLQuery. |
…st hosting transaction on the keychain target, if any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #117.
Problem description
It was impossible to deploy the website using the following command:
Steps to manage the problem
Error Output:
Root cause of the problem
Proposed Solution
Search for the last hosting transaction and, if no such transaction is found, initiate a hosting transaction for the first time
Tests Performed on testnet
I have conducted the following tests to ensure the functionality and robustness of the changes:
Test with an empty keychain:
Test with a keychain containing only "transaction" type entries:
Test with a keychain where the last transaction is not of type "hosting":
Test with a keychain where the last transaction is of type "hosting":