refactor(loader): remove dead module cache-buster#350
Merged
Conversation
The `?t=${Date.now()}` query string was introduced when archgate ran as
a long-lived MCP server process where `loadRuleAdrs()` could be called
multiple times. PR #50 removed the MCP server and ported everything to
CLI commands, but left the cache-buster in place with an updated
comment. Each `archgate check` is now a fresh Bun process — there is no
module cache to bust.
Closes #345 — the broader caching optimization proposed there is not
warranted given current performance (~850ms total, ~188ms rule
execution).
Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Deploying archgate-cli with
|
| Latest commit: |
7f8f707
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ea76ec8.archgate-cli.pages.dev |
| Branch Preview URL: | https://refactor-remove-dead-cache-b.archgate-cli.pages.dev |
Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Contributor
Code Coverage
Full HTML report available in workflow artifacts. Per-directory breakdown
|
- Update ARCH-007 context and consequences to remove outdated "MCP server" framing — the decision (Bun.spawn over Bun.$) is still valid but the rationale cited a deployment mode removed in PR #50 - Remove MCP regression tests from init-project, copilot-settings, and cursor-settings — testing what a function should NOT produce is unnecessary noise eight months after the removal Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Remove test assertions that only existed to guard against re-introduction of features that were removed long ago: - `--prefix` option on `adr import` (replaced by domain-aware remapping) - `defineRules` reference in rules template (removed when satisfies RuleSet replaced it) - `.cursor/rules/archgate-governance.mdc` (removed when Cursor plugin moved to VSIX) - `.cursor/mcp.json` in init-project (MCP server removed in PR #50) These add noise without value — the removed code paths don't exist, TypeScript wouldn't compile references to them, and broader assertions already cover the expected behavior. Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?t=${Date.now()}cache-buster from rule file imports insrc/engine/loader.ts— it was introduced for the MCP server (long-lived process) but became dead code after PR refactor: remove MCP server, port to CLI commands #50 removed the MCP server and ported to CLI commandsarchgate checkis a fresh Bun process with no module cache to bustpathToFileURL()which is still needed for Windows backslash path handlingbaseBranchto.archgate/config.jsonCloses #345 — the broader caching optimization is not warranted (~850ms total, ~188ms rule execution).
Test plan
bun run validatepasses (1202 tests, 27/27 ADR rules, lint, typecheck, knip, build)archgate check --verboseconfirms rules still load and execute correctly