fix(shims): override guard_clean for CI rubygem releases#382
Merged
Conversation
Deploying archgate-cli with
|
| Latest commit: |
b06c5d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c036c281.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-rubygem-guard-clean-over.archgate-cli.pages.dev |
Contributor
Code Coverage
Full HTML report available in workflow artifacts. Per-directory breakdown
|
Bundler's release:guard_clean consistently fails on CI even with gitignored artifacts (Linux/shallow-clone-specific behavior). Override it via define_singleton_method since CI publishes from a clean tag checkout where the guard is unnecessary. Verified locally: full `bundle exec rake release` passes guard_clean, builds the gem, and only fails at rubygem_push (no credentials). Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
rhuanbarreto
force-pushed
the
fix/rubygem-guard-clean-override
branch
from
4e99f17 to
b06c5d3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundler::GemHelper#guard_cleanin the Rakefile to skip the clean-tree check.gitignorefix from fix(shims): gitignore Bundler artifacts that break rubygem publish #380 was necessary but not sufficient — Bundler 4.x'sguard_cleanstill detects generated artifacts even when gitignoredThis is the only shim that hasn't published for v0.41.1 — PyPI, NuGet, Maven, and Go all succeeded on earlier runs.
Test plan
v0.41.1tag, re-runpublish-shims.yml— onlypublish-rubygemneeds to succeed (others will fail with "already exists" which is expected)