Added support for feature = preserve_order#21
Added support for feature = preserve_order#21mitsuhiko wants to merge 1 commit intoarcnmx:masterfrom
Conversation
|
Thanks for the PR! I'm open to including this, but do have a few points that need addressing:
|
|
@arcnmx a lot of the serde ecosystem completely breaks sadly by turning on features. For instance serde-json's |
|
I think this breakage is worse than what happens around arbitrary_precision. It would be better to solve this the way @arcnmx asked, using an opaque map type like how serde_json's preserve_order works. Separately, are there use cases that require this to be a map at all? Otherwise |
|
That's a good point - or alternatively, would it be appropriate to make indexmap the only option if the overhead is comparable? |
This adds support for the
preserve_orderfeature that is also provided byserde_json. The behavior is similar and comes with the same general downsides that it's a global feature.