Skip to content

chore(az.table): use centralized diagnostic id in temp table entity test fixture #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnmoreels wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(az.table): use centralized diagnostic id in temp table entity test fixture #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Arcus.Testing.Storage.Table/TemporaryTableEntity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private TemporaryTableEntity(
/// <exception cref="ArgumentException">Thrown when the <paramref name="accountName"/> or the <paramref name="tableName"/> is blank.</exception>
/// <exception cref="ArgumentNullException">Thrown when the <paramref name="entity"/> is <c>null</c>.</exception>
#pragma warning disable S1133 // Will be removed in v3.0.
[Obsolete("Will be removed in v3.0, please use the " + nameof(UpsertEntityAsync) + " instead which provides exactly the same functionality", DiagnosticId = "ARCUS")]
[Obsolete("Will be removed in v3.0, please use the " + nameof(UpsertEntityAsync) + " instead which provides exactly the same functionality", DiagnosticId = ObsoleteDefaults.DiagnosticId)]
#pragma warning restore S1133
public static Task<TemporaryTableEntity> AddIfNotExistsAsync<TEntity>(
string accountName,
Expand All @@ -74,7 +74,7 @@ public static Task<TemporaryTableEntity> AddIfNotExistsAsync<TEntity>(
/// <param name="logger">The logger instance to write diagnostic information during the lifetime of the test fixture.</param>
/// <exception cref="ArgumentNullException">Thrown when the <paramref name="client"/> or the <paramref name="entity"/> is <c>null</c>.</exception>
#pragma warning disable S1133 // Will be removed in v3.0.
[Obsolete("Will be removed in v3.0, please use the " + nameof(UpsertEntityAsync) + " instead which provides exactly the same functionality", DiagnosticId = "ARCUS")]
[Obsolete("Will be removed in v3.0, please use the " + nameof(UpsertEntityAsync) + " instead which provides exactly the same functionality", DiagnosticId = ObsoleteDefaults.DiagnosticId)]
#pragma warning restore S1133
public static Task<TemporaryTableEntity> AddIfNotExistsAsync<TEntity>(TableClient client, TEntity entity, ILogger logger) where TEntity : class, ITableEntity
{
Expand Down
Loading