Fix pollingGetDevices signature to match Flutter 3.41.x#88
Merged
ardera merged 1 commit intoardera:feat/3.41from Apr 6, 2026
Merged
Conversation
Add missing `forWirelessDiscovery` named parameter to `FlutterpiSshDeviceDiscovery.pollingGetDevices` to match the updated `PollingDeviceDiscovery` base class in Flutter >= 3.41.1. Fixes ardera#87
cbenhagen
added a commit
to cbenhagen/flutterpi_tool
that referenced
this pull request
Feb 21, 2026
Flutter 3.41.x added a `forWirelessDiscovery` named parameter to `PollingDeviceDiscovery.pollingGetDevices`. Add it to the override to fix compilation. Cherry-picked from ardera#88.
|
We verified this on Flutter 3.41.5 (stable, Dart 3.11.3) in a real The One additional detail we hit: after updating to the new Flutter tools API, the test harness also needs a small compatibility fix, otherwise In our local validation, adding a no-op implementation to @Override
void stopExtendedWirelessDeviceDiscoverers() {}So from our side:
|
Owner
|
Thanks! Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
forWirelessDiscoverynamed parameter toFlutterpiSshDeviceDiscovery.pollingGetDevicesto match the updatedPollingDeviceDiscoverybase class in Flutter >= 3.41.1.Fixes #87