feat: compile with new wait_for_app mode#254
Merged
lucarin91 merged 30 commits intoarduino:mainfrom Apr 3, 2026
Merged
Conversation
5 tasks
5 tasks
dido18
requested changes
Mar 3, 2026
lucarin91
commented
Mar 3, 2026
dido18
reviewed
Mar 6, 2026
giulio93
reviewed
Mar 9, 2026
|
|
dido18
approved these changes
Apr 3, 2026
dido18
approved these changes
Apr 3, 2026
gertrude pre-release platform has a not working flash to ram menu option. So it is better to just keep using flash to ram for unoq board.
lucarin91
force-pushed
the
ram-flash-alternative
branch
from
fd1efbb to
3d07965
Compare
dido18
reviewed
Apr 3, 2026
| if platform.SupportFlashToRam() { | ||
| if err := uploadSketchInRam(ctx, w, srv, inst, platform, sketchPath.String(), buildPath.String()); err != nil { | ||
| // Support the legacy ram upload option if there isn't the new wait_linux_boot option. | ||
| if !menuOptions.Has(WaitForApp) && platform.SupportFlashToRam() { |
Contributor
There was a problem hiding this comment.
could we just chek the FQBN ?
Suggested change
| if !menuOptions.Has(WaitForApp) && platform.SupportFlashToRam() { | |
| if !menuOptions.Has(WaitForApp) && platform.FQBN == "arduino:zephyr:unoq" { |
Contributor
Author
There was a problem hiding this comment.
I will just revert for now
mirkoCrobu
pushed a commit
that referenced
this pull request
Apr 7, 2026
* feat: compile with new wait_for_app mode * implement backward compatibility * fixup! implement backward compatibility * redundant sleep * improve check * fixup! improve check * fixup! Merge remote-tracking branch 'origin/main' into ram-flash-alternative * fixup! fixup! Merge remote-tracking branch 'origin/main' into ram-flash-alternative * remove hardcoded fqbn * fixup! remove hardcoded fqbn * fixup! fixup! remove hardcoded fqbn * use menu check instead of version check * fixup! use menu check instead of version check * rename AnimationPin * wip * add better flash to ram check * fixup! add better flash to ram check * add license * remove some hardcoded strings * fixup! remove some hardcoded strings * trigger ci️ * apply code review suggestions * revert SupportFlashToRam gertrude pre-release platform has a not working flash to ram menu option. So it is better to just keep using flash to ram for unoq board.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement the new wait_for_app menu arduino/ArduinoCore-zephyr#369
Change description
Additional Notes
wait for arduino/ArduinoCore-zephyr@main...arduino:ArduinoCore-zephyr:wait_for_app_modeReviewer checklist
main.