Open
Conversation
Allows for passed in configuration of name id policy format. A format of undefined will generate no name id policy block.
Before, this would only look for HTTP-POST login locations. Now, it will extract any location it finds: post, redirect, or artifact. The way this is achieved is not the most beautiful, but allows for easy matching when `#esaml_idp_metadata` is used. Also adds okta-ish test metadata.
Changes the `esaml_idp_metadata` record: `certificate` -> `certificates`, now of type `[binary()]` instead of `binary()`, with `undefined` instead of `[]` winning if there's nothing in the metadata xml document. Test data included (Azure AD).
Add name id to generate_authn_request
Expose SP signature method in config record
Extract all bindings and support multiple certificates when decoding idp metadata
Add support for NotBefore assertion check
Fix deprecation warning, use sha256 for digest
Author
|
@arekinath sorry, I sent the pull request to the wrong fork 😛 Feel free to close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.