Update landing page style - color styling, social icons, donate, phone number#16
Open
Update landing page style - color styling, social icons, donate, phone number#16
Conversation
added 4 commits
August 18, 2018 17:13
…cons, adds facebook+twitter button placeholders, aligns social UI to bottom right
…che/autism-knowledge-base into update-landing-page-style
mwraich
reviewed
Aug 20, 2018
| border-color: #b3ba3f; | ||
| border-width: 1px; | ||
| border-radius: 32px; | ||
| padding: 10px 20px 10px 20px; |
Collaborator
There was a problem hiding this comment.
@willmero do we want pixels or ems? That seems to be the standard in the other files.
mwraich
reviewed
Aug 20, 2018
| </div> | ||
| <div class="main clearfix"> | ||
| <div class="contact-donate-bar"> | ||
| <span class="toll-free">Toll Free: </span> |
mwraich
reviewed
Aug 20, 2018
| a:hover | ||
| { | ||
| color: #026288; | ||
| color: #dae611; |
Collaborator
There was a problem hiding this comment.
@willmero instead of hardcoding these values, lets follow best practice and set them in a variable?
added 3 commits
August 20, 2018 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds: