Skip to content

[GG-181] Use intermediate host for swap moves #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bimboterminator1 merged 13 commits into from
Mar 6, 2026
Merged

[GG-181] Use intermediate host for swap moves #2248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9f240cf
3rd host
bimboterminator1 Feb 18, 2026
4443401
remove phase logic from sm, decompose form_moves, behave test
bimboterminator1 Feb 19, 2026
c1f4b16
fix normal caswe
bimboterminator1 Feb 20, 2026
d6fbe2c
resource estimator refactoring and tests
bimboterminator1 Feb 25, 2026
5631bac
runs
bimboterminator1 Feb 25, 2026
e3329c1
remove func
bimboterminator1 Feb 26, 2026
84bdcda
refactor FileSystemRequirements
bimboterminator1 Feb 26, 2026
858f029
release
bimboterminator1 Feb 26, 2026
0a711b4
tests
bimboterminator1 Feb 28, 2026
d9220b9
tabs
bimboterminator1 Feb 28, 2026
c6c35d9
tests
bimboterminator1 Mar 2, 2026
57b9831
avoid release
bimboterminator1 Mar 2, 2026
6134727
remove func
bimboterminator1 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gpMgmt/bin/ggrebalance
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ def parseargs():
help='Replay lag(in GBs) allowed on mirror when rebalancing the segments.')
parser.add_option('-v', '--verbose', action='store_true', default=False,
help='debug output.')
parser.add_option('--inplace-swap-roles', dest="inplace_swap_roles", action='store_true', default=False,
help='Allows to place primary and mirror at the same host during rebalance.')

# Parse the command line arguments
options, args = parser.parse_args()
Expand Down Expand Up @@ -145,20 +147,20 @@ def validate_options(options, args, parser):

('target_datadirs', ['target_datadirs_file']),

('skip_rebalance', ['mirror_mode']),
('skip_rebalance', ['mirror_mode', 'inplace_swap_roles']),

('clean_required', [
'target_hosts', 'target_hosts_file', 'add_hosts', 'add_hosts_file',
'remove_hosts', 'remove_hosts_file', 'target_datadirs', 'target_datadirs_file',
'target_segment_count', 'mirror_mode', 'skip_rebalance', 'show_plan',
'skip_resource_estimation', 'analyze', 'replay_lag', 'hba_hostnames'
'skip_resource_estimation', 'analyze', 'replay_lag', 'hba_hostnames', 'inplace_swap_roles'
Comment thread
whitehawk marked this conversation as resolved.
]),

('rollback_required', [
'target_hosts', 'target_hosts_file', 'add_hosts', 'add_hosts_file',
'remove_hosts', 'remove_hosts_file', 'target_datadirs', 'target_datadirs_file',
'target_segment_count', 'mirror_mode', 'skip_rebalance', 'show_plan',
'skip_resource_estimation', 'duration', 'end'
'skip_resource_estimation', 'duration', 'end', 'inplace_swap_roles'
]),
]

Expand Down
3 changes: 2 additions & 1 deletion gpMgmt/bin/gprebalance_modules/ggrebalance_sm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ def create_config_file(self, moves: List[LogicalMove]) -> str:
with open(filename, 'w') as fp:
for move in moves:
segment_current_info = move.seg
if not self.lookup_seg(segment_current_info):
is_swap_phase3 = (move.swap_metadata is not None and move.swap_metadata.get('phase') == 3)
if not is_swap_phase3 and not self.lookup_seg(segment_current_info):
self.logger.info(f'Skip segment for gpmovemirrors: {str(segment_current_info)}')
continue
cfg_line = f'{segment_current_info.getSegmentHostName()}|{segment_current_info.getSegmentPort()}|{segment_current_info.getSegmentDataDirectory()} '
Expand Down
Loading