NGSOK-1265 Allow to use * in expected_executor_group_sets#11
Open
giggsoff wants to merge 1 commit into4.5.0-developfrom
Open
NGSOK-1265 Allow to use * in expected_executor_group_sets#11giggsoff wants to merge 1 commit into4.5.0-developfrom
giggsoff wants to merge 1 commit into4.5.0-developfrom
Conversation
Asmoday
reviewed
Feb 18, 2026
| } else { | ||
| if (FLAGS_expected_executor_group_sets == "*") { | ||
| LOG(INFO) << | ||
| "Special case handling for FLAGS_expected_executor_group_sets == “*“"; |
Collaborator
There was a problem hiding this comment.
Will this compile?
Suggested change
| "Special case handling for FLAGS_expected_executor_group_sets == “*“"; | |
| LOG(INFO) << "Special case handling for FLAGS_expected_executor_group_sets == \"*\""; |
Collaborator
Author
There was a problem hiding this comment.
It will as I use another quotes “ instead of ". But let me use your suggestion.
Asmoday
reviewed
Feb 18, 2026
| LOG(INFO) << | ||
| "Special case handling for FLAGS_expected_executor_group_sets == “*“"; | ||
| for (const auto& it : snapshot->executor_groups) { | ||
| exec_group_sets.emplace(exec_group_sets.begin()); |
Collaborator
Author
There was a problem hiding this comment.
It works, but you are right, the order does not matter, so let me use emplace_back.
Asmoday
reviewed
Feb 18, 2026
be/src/service/impala-server.cc
Outdated
| "in each group) is used during planning when no healthy executor group is available. " | ||
| "If this flag is used then any executor groups that do not map to the specified group" | ||
| " sets will never be used to schedule queries."); | ||
| " sets will never be used to schedule queries. If tris flag set to “*“ will populate " |
Collaborator
There was a problem hiding this comment.
Suggested change
| " sets will never be used to schedule queries. If tris flag set to “*“ will populate " | |
| " sets will never be used to schedule queries. If this flag set to “*“ will populate " |
Collaborator
Author
There was a problem hiding this comment.
Thank you, fixed.
Asmoday
requested changes
Feb 18, 2026
giggsoff
force-pushed
the
feature/NGSOK-1265
branch
from
aedef64 to
c615422
Compare
giggsoff
force-pushed
the
feature/NGSOK-1265
branch
from
c615422 to
1c566d0
Compare
The logic will populate all executor groups into Frontend to decide which one to use there. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
feature/NGSOK-1265
branch
from
1c566d0 to
87e5b55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic will populate all healthy executor groups into Frontend to decide which one to use there.