Add optional gasUsed assertion to testrunner output expectations - #489
Open
axic wants to merge 2 commits into
Open
Add optional gasUsed assertion to testrunner output expectations#489axic wants to merge 2 commits into
gasUsed assertion to testrunner output expectations#489axic wants to merge 2 commits into
Conversation
Contributor
Author
|
Please note: before merging this needs to be updated as likely other changes affected the gasUsed already. |
The testrunner JSON output expectation now supports an optional "gasUsed" field. When present, the test fails unless the gas used at that point matches exactly; when absent, gas is ignored. Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
axic
force-pushed
the
testrunner-gasused
branch
from
August 2, 2026 19:45
370d8bd to
0e179d9
Compare
axic
force-pushed
the
testrunner-gasused
branch
from
August 2, 2026 20:37
0e179d9 to
aa54a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added it to three test cases, which use quite a few features of the stdlib.
Pro: Maybe this is too early, but would be nice to track effects.
Con: Very likely many (if not all) stdlib PRs will have to modify these three values.