Skip to content

libevmasm: Add support to import evm assembly json. - #12834

Closed
aarlt wants to merge 24 commits into
developfrom
import-asm-json
Closed

libevmasm: Add support to import evm assembly json.#12834
aarlt wants to merge 24 commits into
developfrom
import-asm-json

Conversation

@aarlt

@aarlt aarlt commented Mar 22, 2022 •
edited by cameel
Loading

Copy link
Copy Markdown
Contributor

Replaces part of #12704.
Replaced by #13673.

Depends on #13576, #13577, #13578 and #13579

Closes #11787.

@aarlt
aarlt force-pushed the import-asm-json branch from 0947640 to deb8665 Compare March 22, 2022 22:06
@aarlt aarlt mentioned this pull request Mar 22, 2022
Closed
@aarlt
aarlt force-pushed the import-export-script branch from 6fe5e7e to 24bebf5 Compare March 23, 2022 20:58
@aarlt
aarlt force-pushed the import-asm-json branch from deb8665 to eb9d13f Compare March 23, 2022 21:08
@aarlt
aarlt force-pushed the import-export-script branch from 24bebf5 to ebac6c5 Compare March 23, 2022 21:10
@aarlt
aarlt force-pushed the import-asm-json branch from eb9d13f to 881844e Compare March 23, 2022 21:11
@aarlt
aarlt changed the base branch from import-export-script to develop March 28, 2022 16:22
@aarlt aarlt mentioned this pull request Mar 28, 2022
Closed
cameel
cameel reviewed Mar 28, 2022
View reviewed changes

@cameel cameel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally wanted to review #12809 so this is just a review of the import test script or now.

Comment thread scripts/ASTImportTest.sh
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread solc/CommandLineInterface.cpp Outdated
@aarlt
aarlt force-pushed the import-asm-json branch 6 times, most recently from af8b818 to 4a8d91d Compare March 28, 2022 23:39
@aarlt
aarlt marked this pull request as ready for review March 29, 2022 03:28
@aarlt
aarlt force-pushed the import-asm-json branch from 3506f50 to a36a1a2 Compare March 29, 2022 20:18
aarlt
aarlt commented Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
aarlt
aarlt commented Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/common.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Mar 29, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
aarlt
aarlt commented Mar 31, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
@aarlt
aarlt force-pushed the import-asm-json branch from f7d9f2a to 24c56db Compare March 31, 2022 23:08
cameel
cameel reviewed Apr 1, 2022
View reviewed changes
Comment thread scripts/ImportExportTest.sh Outdated
Comment thread scripts/ImportExportTest.sh Outdated
cameel
cameel reviewed Apr 1, 2022
View reviewed changes
Comment thread scripts/common.sh Outdated
cameel
cameel reviewed Apr 1, 2022
View reviewed changes
Comment thread scripts/common.sh
aarlt added 20 commits September 14, 2022 17:15
@aarlt
scripts/ImportExportTest.sh: refactorings.
c5e6a5b
@aarlt
scripts/ImportExportTest.sh: add support for 'set -euo pipefail'.
3e2b62a
@aarlt
Refactorings.
d4c8c99
@aarlt
Refactorings.
8e55cac
@aarlt
Assembly::loadFromAssemblyJSON(..) as static factory function.
706e6aa
@aarlt
Assembly::OptimiserSettings: add translateSettings(..).
793adf4
@aarlt
libevmasm/Assembly.cpp: minors.
6c663ac
@aarlt
[solc] CommandLineInterface.cpp: Remove optional parameter in solAsse…
f065760 
…rt(..) usage.
@aarlt
[solc] CommandLineParser: introduction of any_of / none_of.
65d09e7
@aarlt
Minors.
e57c137
@aarlt
Remove Assembly::OptimiserSettings::translateSettings(..).
4f76877
@aarlt
[libsolidity] interface/CompilerStack.h: Remove m_evmAssemblyJson.
5c9c88c
@aarlt
[libsolutil] JSON: Add ofType, ofTypeIfExists & getOrDefault.
555d774
@aarlt
[libsolutil] JSON: Add get function.
1451520
@aarlt
CommandLineParser: Remove any_of / none_of.
1774de0
@aarlt
Minors.
91e3b65
@aarlt
[scripts] ImportExportTest.sh: shellcheck source=scripts/common.sh
0e9505c
@aarlt
scripts/ImportExportTest.sh: refactorings.
bf5565d
@aarlt
solc/CommandLineInterface.cpp: fix style.
b56121f
@aarlt
scripts/ImportExportTest.sh: Fix "${OUTPUT[*]}".
b174aba
@aarlt aarlt mentioned this pull request Sep 28, 2022
Merged
@aarlt
aarlt marked this pull request as draft September 28, 2022 02:15
@aarlt aarlt added the has dependencies The PR depends on other PRs that must be merged first label Sep 28, 2022
This was referenced Sep 28, 2022
Merged
Merged
Merged
@aarlt aarlt self-assigned this Nov 1, 2022
@aarlt aarlt mentioned this pull request Nov 2, 2022
Merged
6 tasks
@aarlt aarlt closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nishant-sachdeva nishant-sachdeva Awaiting requested review from nishant-sachdeva
@cameel cameel Awaiting requested review from cameel
@chriseth chriseth Awaiting requested review from chriseth
1 more reviewer
@stackenbotten stackenbotten stackenbotten left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@aarlt aarlt

Labels

has dependencies The PR depends on other PRs that must be merged first priority review We want this get the review of this PR to a conclusion ASAP.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler mode to reimport assembly json.

6 participants

@aarlt @leonardoalt @cameel @chriseth @stackenbotten @ekpyron