Feat/cmd k comp - #118
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
4 issues found across 124 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/(docs)/docs/multiple-selector/page.tsx">
<violation number="1" location="app/(docs)/docs/multiple-selector/page.tsx:91">
P3: cli value uses plural 'options' but the filename uses singular 'option'. Should match for consistent install commands.</violation>
</file>
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
| title="Disable Option" | ||
| path="app/(docs)/docs//multiple-selector/usage/multiple-selector-with-disable-option.tsx" | ||
| cli="@spectrumui/multiple-selector-with-disable-option" | ||
| cli="@spectrumui/multiple-selector-with-disable-options" |
There was a problem hiding this comment.
P3: cli value uses plural 'options' but the filename uses singular 'option'. Should match for consistent install commands.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/(docs)/docs/multiple-selector/page.tsx, line 91:
<comment>cli value uses plural 'options' but the filename uses singular 'option'. Should match for consistent install commands.</comment>
<file context>
@@ -88,7 +88,7 @@ const MultipleSelectorPage = () => {
title="Disable Option"
path="app/(docs)/docs//multiple-selector/usage/multiple-selector-with-disable-option.tsx"
- cli="@spectrumui/multiple-selector-with-disable-option"
+ cli="@spectrumui/multiple-selector-with-disable-options"
>
<MultipleSelectorWithDisabledOption />
</file context>
Suggested change
| cli="@spectrumui/multiple-selector-with-disable-options" | |
| cli="@spectrumui/multiple-selector-with-disable-option" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a keyboard-first Command Palette (Cmd/Ctrl+K) and an Accordion demo/registry with docs. Also improves CI by validating the registry and building with dummy env vars so builds pass.
New Features
@spectrumui/command-palette: accessible, animated palette with search, navigation, theme toggles, and repo actions; opens with Cmd/Ctrl+K; built withframer-motion,lucide-react, andnext-themes. Docs: new page with demo; registry itemscommand-paletteandcommand-palette-demo; docs nav shows a “new” badge.@spectrumui/accordion: adds registry item andaccordion-demo; accordion docs now include theclihint for@spectrumui/accordion.Refactors
.github/workflows/ci.ymlrunsyarn test:registry,npx shadcn@latest build, andyarn buildon Node 20; injects dummy envsNEXT_PUBLIC_SUPABASE_URL,NEXT_PUBLIC_SUPABASE_ANON_KEY,SUPABASE_SERVICE_ROLE_KEY,RESEND_API_KEY,DODO_PAYMENTS_API_KEY,DODO_PAYMENTS_RETURN_URL,DODO_PAYMENTS_ENVIRONMENT,AUTH_SECRET.animatedcard), fixed CLI ids (e.g.,@spectrumui/ink), corrected paths, and added missingclihints in docs previews; refactored Multiple Selector usage paths (e.g.,with-disable-options,manually-controlled) and imports.test:registryand settestto run it; added.agents/component_design_guidelines.mdas the canonical guide.Written for commit 89a22aa. Summary will update on new commits.