Small fixes#36
Open
oxanayoxana wants to merge 3 commits intoarkency:masterfrom
Open
Conversation
Contributor
oxanayoxana
commented
Nov 16, 2019
oxanayoxana
commented
- Updated Slack link in readme
- There was a problem while trying to edit your own project - fixed it
- In navbar 'Sign in with Github ' link was broken, because now you can not just sign, you have to chose your role. Don't know how to fix it properly - any ideas? For now I just made a redirect to the root page, so that it doesn't throw error.
denys-medynskyi
suggested changes
Nov 16, 2019
denys-medynskyi
left a comment
denys-medynskyi
left a comment
There was a problem hiding this comment.
Check out my feedback. Let me know anything wrong/ not clear about them
| def repo | ||
| @repos.map(&:name) | ||
| def fetch_repo | ||
| @repo = @repos.map(&:name) |
There was a problem hiding this comment.
This method returns an array of names, right?
Why does it called in singular fetch_repo?
|
|
||
| def repos | ||
| def fetch_repos | ||
| @client = Octokit::Client.new |
There was a problem hiding this comment.
Can we move all these 3 lines in 1 ServiceObject?
For example in the end we would get the following:
class FetchRepo
def call
# client / github user fetched
client.repos(@github_user.login, query: { type: 'owner', sort: 'asc' })
end
end
And in the controller:
@repos = FetchRepos.call
What do you think about it?
Contributor
Author
There was a problem hiding this comment.
@deny7ko look, I've managed to do that! ) But why the changes don't show up hmm...
| def edit; end | ||
|
|
||
| def create | ||
| @project = Project.new(project_params) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.