Skip to content

arm64: dts: rockchip: fix adc-keys press-threshold-microvolt for recomputer devkits#483

Merged
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
Seeed-Studio:fix/adc-keys-threshold
May 28, 2026
Merged

arm64: dts: rockchip: fix adc-keys press-threshold-microvolt for recomputer devkits#483
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
Seeed-Studio:fix/adc-keys-threshold

Conversation

@mingzhangqun
Copy link
Copy Markdown
Contributor

Summary

  • Fix volumeup-key press-threshold-microvolt value from 1750 to 1750000 (1.75V) for recomputer rk3576 and rk3588 devkit boards
  • The original value was off by a factor of 1000, causing the ADC key detection to malfunction

Test plan

  • Verify adc-keys node reports correct voltage threshold in sysfs
  • Test volume up key functionality on recomputer rk3576-devkit
  • Test volume up key functionality on recomputer rk3588-devkit

Copy link
Copy Markdown
Member

@SuperKali SuperKali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…mputer devkits

The volumeup-key press-threshold-microvolt was set to 1750 instead of
1750000 (1.75V), off by a factor of 1000. Fix for both rk3576 and rk3588
recomputer devkit boards.
@SuperKali SuperKali force-pushed the fix/adc-keys-threshold branch from 55fb8d1 to 4799981 Compare May 28, 2026 18:13
@SuperKali SuperKali merged commit 6475fed into armbian:rk-6.1-rkr5.1 May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants