[pull] master from spinnaker:master#10
Open
pull[bot] wants to merge 74 commits into
Open
Conversation
Co-authored-by: root <root@fff03430e3e7>
Co-authored-by: root <root@b363a8ce22ba>
Co-authored-by: root <root@e87e1aef4e07>
|
PR title: Reason: Because we enforce conventional commits and squash merges of PRs, the PR Title becomes the commit title. For more information, see the Conventional Commits specification. Some common examples are: |
Co-authored-by: root <root@b8ac3e53ca36>
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v1...v2) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: root <root@f3c95bdfe066>
Co-authored-by: root <root@e299e24f53a9>
Co-authored-by: root <root@9bcdea888557>
…n to skip invalid objects (#1450) * fix(sql): teach SqlStorageService.loadObjects to skip invalid objects and return the valid ones. This allows the cache to populate and gives the health check a chance to succeed. * fix(sql): teach SqlStorageService.loadObjectsNewerThan to skip invalid objects and return the valid ones. This allows the cache to populate and gives the health check a chance to succeed.
…t docker image (#1451) * fix(core): don't include CommonStorageServiceDAOConfig when redis is enabled The Redis*DAO family of beans handle this functionality when redis is enabled, so disable CommonStorageServiceDAOConfig. This fixes this error on startup: *************************** APPLICATION FAILED TO START *************************** Description: Parameter 0 of method pipelineTemplateDAO in com.netflix.spinnaker.front50.config.CommonStorageServiceDAOConfig required a bean of type 'com.netflix.spinnaker.front50.model.StorageService' that could not be found. The injection point has the following annotations: - @org.springframework.beans.factory.annotation.Autowired(required=false) Action: Consider defining a bean of type 'com.netflix.spinnaker.front50.model.StorageService' in your configuration. * chore(build): give local gradle builds more memory Match what github actions uses to prevent e.g. > Task :front50-s3:compileJava Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: /Users/dbyron/src/spinnaker/salesforce/front50/front50-s3/src/main/java/com/netflix/spinnaker/front50/model/S3StorageService.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. Expiring Daemon because JVM heap space is exhausted * feat(docker): add HEALTHCHECK to facilitate testing container startup * feat(build): add front50-integration module to exercise the just-built docker image * feat(integration): run integration test in pr builds multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59 * feat(integration): run integration test in branch builds
Co-authored-by: root <root@ecdf0ca0fcc6>
…oller.save (#1452) * refactor(web/test): construct Pipeline objects in the first place instead of making Maps and casting * fix(web): restore check for regenerateCronTriggerIds in PipelineController.save https://github.com/spinnaker/front50/pull/1035/files#diff-9b514be177faf5444c86a88ab6bb9e6a0add032bfa67862bc8e33b17c4bb9cc9L159 removed it, but orca's SavePipelineTask still sets it. * refactor(web): adjust pipeline triggers directly The comment in https://github.com/spinnaker/front50/pull/987/files#r515405296 is no longer true after #1035. Pipeline.getTriggers no longer makes a copy, so there's no need to get/modify/set. --------- Co-authored-by: Jason <mcintoshj@gmail.com>
Co-authored-by: root <root@28ff04fd44ba>
…#1457) and use an additional filter to clean up the code. With [pipeline.getTriggers()](https://github.com/spinnaker/front50/pull/1035/files#diff-0b2bc300fd3965c64ba4184955384aa8609cace04e1c015b31ef4a83552e53d1R36) implemented as an accessor, ensureCronTriggersHaveIdentifier was already mutating the pipeline. Let's make that more obvious by making it return void and adding some javadoc.
Co-authored-by: root <root@8b70676aa6c3>
Co-authored-by: root <root@cfe88d4b31d9>
Co-authored-by: root <root@8b2740453d3d>
* feat(migrations): Support for migrations defined in plugins The current implementation of the MigrationRunner is initialized before any migrations in plugins are defined. Even if they are defined using `@ExposeToApp`, the beans are never picked up by the MigrationRunner bean. This fix looks up Migration beans directly from the applicationContext on every run, and will also delay the first run with 10 seconds in order to give some time to plugins to be initialized. * Fix import order * Add tests for MigrationRunner --------- Co-authored-by: Jason <mcintoshj@gmail.com>
Co-authored-by: root <root@759306dd2744>
Before:
```
$ ./gradlew front50-sql-mysql:dI --dependency mysql-connector-java --configuration runtimeClasspath
> Task :front50-sql-mysql:dependencyInsight
mysql:mysql-connector-java:8.0.33
Variant runtime:
| Attribute Name | Provided | Requested |
|--------------------------------|--------------|--------------|
| org.gradle.status | release | |
| org.gradle.category | library | library |
| org.gradle.libraryelements | jar | jar |
| org.gradle.usage | java-runtime | java-runtime |
| org.gradle.dependency.bundling | | external |
| org.gradle.jvm.environment | | standard-jvm |
| org.gradle.jvm.version | | 11 |
Selection reasons:
- By constraint
- Forced
mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.kork:kork-bom:7.227.0
\--- runtimeClasspath
mysql:mysql-connector-java:8.0.12 -> 8.0.33
\--- runtimeClasspath
```
After:
```
$ ./gradlew front50-sql-mysql:dI --dependency mysql-connector-java --configuration runtimeClasspath
> Task :front50-sql-mysql:dependencyInsight
mysql:mysql-connector-java:8.0.33
Variant runtime:
| Attribute Name | Provided | Requested |
|--------------------------------|--------------|--------------|
| org.gradle.status | release | |
| org.gradle.category | library | library |
| org.gradle.libraryelements | jar | jar |
| org.gradle.usage | java-runtime | java-runtime |
| org.gradle.dependency.bundling | | external |
| org.gradle.jvm.environment | | standard-jvm |
| org.gradle.jvm.version | | 11 |
Selection reasons:
- By constraint
- Forced
mysql:mysql-connector-java:8.0.33
\--- io.spinnaker.kork:kork-bom:7.227.0
\--- runtimeClasspath
mysql:mysql-connector-java -> 8.0.33
\--- runtimeClasspath
```
* fix(web): Retrieve dependent pipelines correctly * fix(web): Add tests * fix(web): Add test proving the broken behaviour of earlier dependentPipelines API
Co-authored-by: root <root@2fd9414555e9>
Co-authored-by: root <root@4f16d982b5e9>
…fix (#1466) * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor * fix(migrator): GCS to SQL migrator APPLICATION_PERMISSION fix/refactor
* chore(build): enable cross compilation plugin for Java 17 * chore(build): fix usage of size property on lists
* chore(dependencies): Autobump korkVersion * refactor(mysql): update mysql connector coordinate during upgrade to spring boot 2.7.x In spring boot 2.7.8 onwards mysql connector coordinate `mysql:mysql-connector-java` has been removed and only `com.mysql:mysql-connector-j` coordinate exist. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#mysql-jdbc-driver So, updating the mysql connector coordinate as `com.mysql:mysql-connector-j` with spring boot upgrade to 2.7.18. https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.7.18/spring-boot-dependencies-2.7.18.pom --------- Co-authored-by: root <root@51dce6428a99> Co-authored-by: j-sandy <30489233+j-sandy@users.noreply.github.com>
Co-authored-by: root <root@66f7060f0a52>
Co-authored-by: root <root@0e8a9747aac9>
Co-authored-by: root <root@76e4fcc2b807>
* chore(dependencies): Autobump korkVersion * chore(dependencies): remove force dependencies for google-api * fix(gcs): add dummy metadata to updateLastModified blob with newer client * test(gcs): update test that match new google cloud client --------- Co-authored-by: root <root@b2d607896795> Co-authored-by: Edgar Garcia <edgar.garcia@harness.io>
Co-authored-by: root <root@c407cd7c4eac>
…s/{application} endpoint (#1504)
* feat(pipelineController): add a pipelineNameFilter query param to the /pipelines/{application} endpoint
This adds a pipelineNameFilter query parameter to the /pipelines/{application} endpoint. If pipelineNameFilter is present, the endpoint will return a list of pipelines whose pipeline name contains the pipelineNameFilter.
This change is necessary to enable some optimizations in the front end - namely, filtering pipelines on the backend, instead of always querying for every pipeline in an application, and filtering the list in the front end.
* feat(pipeline): check for null pipeline name and log error
* fix(test/pipeline): updating tests and fixing getPipelinesByApplication implementation.
* fix(pipeline): make the comparison case insensitive.
* refactor(tests): convert groovy tests to java
* fix(tests): address minor issues
---------
Co-authored-by: Richard Timpson <richard.timpson@salesforce.com>
Co-authored-by: root <root@f15c9eb9818b>
* chore(java): Full Java 17 support only * chore(java): Full Java 17 support only
Co-authored-by: root <root@7a9eafb286db>
* chore(java): Full Java 17 support only * chore(java): Full Java 17 support only * chore(upgrades): Update OS to latest supported releases
Co-authored-by: root <root@0e2c439806f3>
and, once it's tagged, move the release-1.36.x branch there. We created the release-1.36.x branch too early, so the [2.36.0 build](https://github.com/spinnaker/front50/actions/runs/11925822078/job/33238616660) failed: Run BRANCHES=$(git branch -r --contains refs/tags/v2.36.0) BRANCHES is ' origin/master origin/release-1.36.x' NUM_BRANCHES is '2' exactly one branch required to release front50, but there are 2 ( origin/master origin/release-1.36.x)
* fix(openapi): Rewrite Swagger to OpenAPI annotations * chore(deps): bump latest kork version --------- Co-authored-by: Edgar Garcia <edgar.garcia@harness.io>
Co-authored-by: root <root@c80011301680>
* chore(dependencies): Autobump fiatVersion * refactor(retrofit2): refactor the code to align with the retrofit2 upgrade of fiat-api * refactor(retrofit2): use retrofit-mock library instead of mocking Call. --------- Co-authored-by: root <root@4f180b5207b5> Co-authored-by: kirangodishala <kiran@opsmx.io>
Co-authored-by: root <root@935cb5015720>
Co-authored-by: root <root@d6aa4183a5bc>
Co-authored-by: root <root@796c595fa7d4>
specifically: rm /var/lib/dpkg/info/libc-bin.* && apt-get clean to fix errors like #9 101.2 qemu: uncaught target signal 11 (Segmentation fault) - core dumped #9 101.6 Segmentation fault (core dumped) #9 101.7 qemu: uncaught target signal 11 (Segmentation fault) - core dumped #9 102.1 Segmentation fault (core dumped) #9 102.1 dpkg: error processing package libc-bin (--configure): #9 102.1 installed libc-bin package post-installation script subprocess returned error exit status 139 from https://github.com/spinnaker/front50/actions/runs/13294117039/job/37121766728?pr=1528 suggestion from https://stackoverflow.com/a/78107622
Co-authored-by: root <root@b3aa3eba8e03>
Co-authored-by: root <root@819552d2cd6b>
from e.g. https://github.com/spinnaker/front50/actions/runs/13421258969/job/37494202537 Run BRANCHES=$(git branch -r --contains refs/tags/v2.38.0) BRANCHES is ' origin/HEAD -> origin/master origin/master' NUM_BRANCHES is '2' exactly one branch required to release front50, but there are 2 ( origin/HEAD -> origin/master origin/master)
Co-authored-by: root <root@7006d21ea161>
Co-authored-by: root <root@3d3c5f1ddb64>
Co-authored-by: root <root@37d4e0bf47bb>
Co-authored-by: root <root@37d26b4fc68c>
Co-authored-by: root <root@07aba17c0fd0>
Co-authored-by: root <root@23070a6ef06a>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )