Skip to content

fix(gate): Add a property to default on calls to orca to include nested pipelines #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmcintosh merged 2 commits into from
Apr 14, 2026
+13 −4
Merged

fix(gate): Add a property to default on calls to orca to include nested pipelines #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f80233
fix(gate): Add a property to default on calls to orca to include nest…
jasonmcintosh Apr 14, 2026
ead0ed9
fix(gate): Add a property to default on calls to orca to include nest…
jasonmcintosh Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gate-core/src/main/java/com/netflix/spinnaker/gate/services/internal/OrcaService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ List getSubsetOfExecutions(
@Query("executionIds") String executionIds,
@Query("limit") Integer limit,
@Query("statuses") String statuses,
@Query("expand") boolean expand);
@Query("expand") boolean expand,
@Query("includeNestedExecutions") boolean includeNestedExecutions);

@Headers("Accept: application/json")
@GET("/applications/{application}/pipelines/search")
Expand Down
14 changes: 11 additions & 3 deletions gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/ExecutionsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
@RestController
public class ExecutionsController {

private OrcaServiceSelector orcaServiceSelector;
private final OrcaServiceSelector orcaServiceSelector;

@Autowired
public ExecutionsController(OrcaServiceSelector orcaServiceSelector) {
Expand Down Expand Up @@ -62,15 +62,23 @@ List getLatestExecutionsByConfigIds(
description =
"Expands each execution object in the resulting list. If this value is missing, it is defaulted to true.")
@RequestParam(value = "expand", defaultValue = "true")
boolean expand) {
boolean expand,
@Parameter(
description =
"Expands the pipeline refs to be real pipeline references AND the execution data. For backwards compliant calls when pipeline ref is turned on. Set to true or false lowercase as needed. Defaults to false or a property on fallback")
@RequestParam(
value = "includeNestedExecutions",
defaultValue = "${orca.defaults.includeNestedExecutionsByDefault:false}")
boolean includeNestedExecutions) {
if ((executionIds == null || executionIds.trim().isEmpty())
&& (pipelineConfigIds == null || pipelineConfigIds.trim().isEmpty())) {
return Collections.emptyList();
}

return orcaServiceSelector
.select()
.getSubsetOfExecutions(pipelineConfigIds, executionIds, limit, statuses, expand);
.getSubsetOfExecutions(
pipelineConfigIds, executionIds, limit, statuses, expand, includeNestedExecutions);
}

@Operation(
Expand Down
Loading