add logic to strip UTF8 BOM#13
Open
floyd-may wants to merge 1 commit intoarnauddri:masterfrom
floyd-may:utf8-bom-fix
Open
add logic to strip UTF8 BOM#13floyd-may wants to merge 1 commit intoarnauddri:masterfrom floyd-may:utf8-bom-fix
floyd-may wants to merge 1 commit intoarnauddri:masterfrom
floyd-may:utf8-bom-fix
Conversation
floyd-may
commented
Dec 27, 2016
| @@ -0,0 +1 @@ | |||
| <h1>Example HTML Template</h1> | |||
Author
There was a problem hiding this comment.
Doesn't really show very well here, but this file has a UTF8 BOM.
Author
|
I changed the way the assertions work so that it's easier to see why the test fails. You can see that in the failing Travis build 😄 I also see that the CI build is failing because of the order that the files appear in the output. I suspect that the order is OS dependent. It may be that processing the files asynchronously might not be the best option for keeping the tests stable. Just my $0.02. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #12.