Skip to content

ci: debug mac signing in preview builds #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arnoldhao wants to merge 3 commits into from
Closed

ci: debug mac signing in preview builds #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07806b9
ci: debug mac signing in preview builds
arnoldhao May 29, 2026
cef36f5
ci: debug mac signing in preview builds
arnoldhao May 29, 2026
dcb7a97
Merge branch 'chore/codesign_fix' of https://github.com/arnoldhao/hus…
arnoldhao May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,33 @@ jobs:
- name: Build app
run: npm run build

- name: Validate preview macOS signing secrets
if: matrix.platform == 'macos'
shell: bash
env:
CSC_LINK: ${{ secrets.MAC_CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.MAC_CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: |
test -n "$CSC_LINK" || { echo "::error::Missing MAC_CSC_LINK secret"; exit 1; }
test -n "$CSC_KEY_PASSWORD" || { echo "::error::Missing MAC_CSC_KEY_PASSWORD secret"; exit 1; }
test -n "$APPLE_ID" || { echo "::error::Missing APPLE_ID secret"; exit 1; }
test -n "$APPLE_APP_SPECIFIC_PASSWORD" || { echo "::error::Missing APPLE_APP_SPECIFIC_PASSWORD secret"; exit 1; }
test -n "$APPLE_TEAM_ID" || { echo "::error::Missing APPLE_TEAM_ID secret"; exit 1; }

- name: Package preview app (macOS)
if: matrix.platform == 'macos'
timeout-minutes: 45
env:
DEBUG: electron-builder,electron-osx-sign*,electron-notarize*
CSC_FOR_PULL_REQUEST: true
CSC_LINK: ${{ secrets.MAC_CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.MAC_CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: npx electron-builder --mac --${{ matrix.arch }} --publish never

- name: Package preview app (Windows)
Expand All @@ -98,7 +123,14 @@ jobs:

- name: Verify macOS signing
if: matrix.platform == 'macos'
run: npm run verify:macos-signing -- ${{ matrix.app_path }}
run: npm run verify:macos-signing -- --require-developer-id ${{ matrix.app_path }}

- name: Verify macOS notarization
if: matrix.platform == 'macos'
shell: bash
run: |
xcrun stapler validate ${{ matrix.app_path }}
spctl --assess --type execute --verbose=4 ${{ matrix.app_path }}

- name: Verify native module (Windows)
if: matrix.platform == 'windows'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ jobs:
test -n "$APPLE_TEAM_ID" || { echo "::error::Missing APPLE_TEAM_ID secret"; exit 1; }

- name: Package app (macOS)
timeout-minutes: 45
env:
DEBUG: electron-builder,electron-osx-sign*,electron-notarize*
CSC_LINK: ${{ secrets.MAC_CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.MAC_CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
Expand Down
Loading