Open
Conversation
Added support to run Running KnowledgeExtractor from Windows by adding clingo 4.5.4 for win64 and modifying the system call in ClingoExecutor Signed-off-by: Adham Abozaeid <adham.abozaeid@gmail.com>
Append processed file name in property knowextfrom. Code to skip processed file are already there. Also close bufferedReader in getSetOfDoneFiles() Signed-off-by: Adham Abozaeid <adham.abozaeid@gmail.com>
Execution hangs regularly while calling clingo. This can be workedaround by timing out while waiting for clingo process to execute, and skip the line if it timed out. Using 5sec timeout for now Signed-off-by: Adham Abozaeid <adham.abozaeid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 patches to add more stability to KnowledgeExtractor on Windows:
1- Modified ClingoExecutor.callASPusingFilesList() to use runtime to execute clingo on Windows.
2- Modified KnowledgeExtractor to save processed file names in file knowextfrom. This way the code can rerun on the same file set safely same way SentenceParser does.
3- Code was hanging very frequently after processing 3~4 files. This was root caused to come from the runtime process that calls clingo but sometimes never returns. Might be a problem specific to the Windows version of clingo since you could run it for longer time, but it's safer to add a timeout while calling process.waitfor() for all OSs anyways
Thanks,
Adham