Open
Conversation
| return inn | ||
|
|
||
| def build(self): | ||
| def build(self, **kwargs): |
Owner
There was a problem hiding this comment.
I think it would be nice to throw an exception here if the size of the callback data is more than 64 bytes.
Previously, it was guaranteed that no telegram API exception occurs.
Please, see: https://core.telegram.org/bots/api#inlinekeyboardmarkup
nickborovik
commented
Sep 19, 2020
Comment on lines
+88
to
+89
| if len(list(chain.from_iterable(kwargs.values()))) > 22: | ||
| raise Exception("Too long string passed in value of kwargs or too many values") |
Author
There was a problem hiding this comment.
if i got you right, here an example of exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for useful calendar!
When i used it, i needed to transfer data between calendars.
So i thought maybe someone like me needed to use this feature later.
Also for this feature i needed to replace split symbol from '_' to '#'.
It's because in **kwargs you can use variables with underlines like 'some_date'.