Merged
Conversation
…tion header and remove the credentials from the request body
chriskapp
commented
Jun 2, 2025
sidler
approved these changes
Jun 2, 2025
marcreichel
requested changes
Jun 3, 2025
Co-authored-by: Marc Reichel <marc.reichel@artemeon.de>
marcreichel
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
ClientCredentialsDecoratorsend theclient_idandclient_secretin the Body, this does not strictly follow the OAuth2 spec s. https://datatracker.ietf.org/doc/html/rfc6749#section-4.4.2 since we need to send the client_id and client_secret also as Basic-Auth header.