Merged
Conversation
wasip1 is effectively legacy. The WASI preview 2 target (wasm32-wasip2) is stable in Rust and fully supported by wasmtime 24+. No code changes needed, wit-bindgen 0.36 works with both targets. Closes #1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wasm32-wasip1towasm32-wasip2across all configs, CI workflows, and docsFiles changed
.cargo/config.toml- default build targetrust-toolchain.toml- toolchain target.github/workflows/ci.yml- CI build/lint/test target.github/workflows/release.yml- release build targetREADME.md- documentation referencesdocs/TEST_PLAN.md- test plan referencesTest plan
cargo build --release --target wasm32-wasip2succeedscargo clippy --target wasm32-wasip2 -- -D warningspassescargo test --target <host>passes (12/12 tests)cargo fmt --checkpassesCloses #1