feat(navigation): add featuredLinksSet and orderedSetID; add orderedSetID to createFeaturedLink

[nickskalkin]

Adds support for managing navigation visual components from Forque.

NavigationVersion:

• Adds an orderedSetID field
• Adds a featuredLinksSet field that resolves a list of FeaturedLink entries associated with the navigation version’s ordered_set_id

Example:

{
  navigationVersion(groupID: "whats-new") {
    featuredLinksSet {
      title
      subtitle
      image {
        url
      }
    }
  }
}

Response:

{
  "data": {
    "navigationVersion": {
      "featuredLinksSet": [
        {
          "title": "Inside Michael Sherman’s Collection",
          "subtitle": "Collector Spotlight",
          "image": {
            "url": "https://d32dm0rphc51dk.cloudfront.net/b4VmSpAIXNEbaclTjmY3uw/large_rectangle.jpg"
          }
        }
      ]
    }
  }
}

CreateFeaturedLink mutation:

• Adds an optional orderedSetID argument to createFeaturedLink input.
• When orderedSetID is provided, the mutation now creates the featured link and adds the created link to the specified ordered set

[claude]

🟡 Non-atomic two-step operation: If addSetItemLoader fails after the featured link is already created, the featured link will exist as an orphan (created but not added to the ordered set). The catch block will format this as a GravityMutationError or re-throw, making it look like the entire operation failed — but the link was actually created.

This may be acceptable given the architecture, but worth considering whether the caller needs to know about this partial-failure state (e.g., returning the created link's ID even on set-addition failure so it can be cleaned up or retried).

[claude]

Code Review

Summary

This PR adds support for associating featured links with ordered sets via a new orderedSetID parameter on the createFeaturedLink mutation, and exposes a featuredLinksSet field (plus orderedSetID) on NavigationVersion to read them back. This enables navigation versions to have visual components backed by featured links in ordered sets.

Issues Found

• 🟡 Important: Non-atomic two-step mutation in createFeaturedLinkMutation.ts (lines 99–109) — the featured link is created first, then added to the ordered set. If the second call fails, an orphaned featured link exists but the error response makes it look like nothing was created. Left an inline comment with details.

Areas Reviewed

• Architecture & Design: Clean separation — mutation handles the write side, NavigationVersion handles the read side via setItemsLoader. The orderedSetID field on NavigationVersion is a nice addition for admin tooling.
• Security: No concerns. Authorization is delegated to backend loaders as expected.
• Bugs & Edge Cases: The featuredLinksSet resolver correctly returns null when ordered_set_id is absent. The setItemsLoader is available in both authenticated and unauthenticated contexts (confirmed via loader definitions), so this won't blow up for public queries.
• Testing: Good coverage — tests cover the happy path for both mutation and query sides, the addSetItemLoader missing case, and the empty set case. One minor gap: no test for featuredLinksSet when ordered_set_id is null/undefined on the navigation version (though the code path is straightforward).

Overall this is a clean, well-structured PR. The non-atomic mutation concern is the only notable item, and it may be acceptable given the system's architecture.

🤖 Generated with Claude Code

[dblandin]

LGTM 👍🏼

[dblandin]

I missed this earlier but we should be able to make this a non-nullable list with non-nullable FeaturedLinkType entries.

That should reduce the amount of null checks needed in Force.

[dblandin]

suggestion: Also: since we're no longer returning a Set type here - should we drop the Set suffix? Maybe just featuredLinks?