feat(unstitching): unstitch confirm password mutation#7508
Merged
Conversation
egdbear
commented
Mar 10, 2026
| startAt: "2025-01-01T12:00:00.000Z", | ||
| endAt: "2025-01-01T18:00:00.000Z", | ||
| formattedTimeZone: "(GMT-05:00) New York", | ||
| formattedTimeZone: expect.stringMatching( |
Contributor
There was a problem hiding this comment.
It wouldn't be daylight savings time without one of these every year! Thanks.
Contributor
b6abd43 to
9c5b7da
Compare
9c5b7da to
2e8273e
Compare
Contributor
Code ReviewSummaryThis PR unstiches the Issues FoundNo blocking or important issues found. The PR follows the established unstitching pattern cleanly and matches existing conventions (e.g., Areas Reviewed
Looks good to merge. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the stitched Gravity
confirmPasswordmutation with a metaphysics implementation behind theUSE_UNSTITCHED_CONFIRM_PASSWORDfeature flag, following the same pattern as recordArtworkView.A new
POST /api/v1/me/confirm_passwordREST endpoint was added in gravity https://github.com/artsy/gravity/pull/19860 to support this.The schema is kept identical to the existing Gravity mutation (
passwordinput,validboolean output) to avoid breaking any clients. This mutation is actively used in Force for 2FA setup flows (app authenticator, SMS, disable factor, regenerate backup codes). It is not used in Eigen.