Conversation
|
@arttor can you please help with review. Thank you |
|
looks good. can you please add affinity to one of the resoruces in https://github.com/arttor/helmify/blob/main/test_data/sample-app.yaml and regenerate examples? See: https://github.com/arttor/helmify/blob/main/test_data/sample-app.yaml |
Done |
| labels: | ||
| app: nginx | ||
| spec: | ||
| affinity: {{- toYaml .Values.web.affinity | nindent 8 }} |
There was a problem hiding this comment.
I can see that affinity was added to myapp deployment and it was correctly templated and added to values.yaml. But why manifests without affinity in soruce were templated?
| name: fluentd-elasticsearch | ||
| {{- include "app.selectorLabels" . | nindent 8 }} | ||
| spec: | ||
| affinity: {{- toYaml .Values.fluentdElasticsearch.affinity | nindent 8 }} |
There was a problem hiding this comment.
I can see that affinity was added to myapp deployment and it was correctly templated and added to values.yaml. But why manifests without affinity in soruce were templated?
| spec: | ||
| template: | ||
| spec: | ||
| affinity: {{- toYaml .Values.cronJob.affinity | nindent 12 }} |
There was a problem hiding this comment.
I can see that affinity was added to myapp deployment and it was correctly templated and added to values.yaml. But why manifests without affinity in soruce were templated?
| backoffLimit: {{ .Values.batchJob.backoffLimit }} | ||
| template: | ||
| spec: | ||
| affinity: {{- toYaml .Values.batchJob.affinity | nindent 8 }} |
There was a problem hiding this comment.
I can see that affinity was added to myapp deployment and it was correctly templated and added to values.yaml. But why manifests without affinity in soruce were templated?
3 participants
Adds support for affinity field under Pod resource