CMakeLists.txt: allow flags passed on the command line to win over bu…#107
Open
tpetazzoni wants to merge 1 commit intoartyom-beilis:masterfrom
Open
CMakeLists.txt: allow flags passed on the command line to win over bu…#107tpetazzoni wants to merge 1 commit intoartyom-beilis:masterfrom
tpetazzoni wants to merge 1 commit intoartyom-beilis:masterfrom
Conversation
…ilt-in flags CMakeLists.txt and booster/CMakeLists.txt define some flags in CXX_FLAGS, and then set CMAKE_CXX_FLAGS in a way that causes the flags in CXX_FLAGS to override the ones passed (for example on the command line through CMAKE_CXX_FLAGS). This prevents the user from overriding those compiler flags in CXX_FLAGS. A specific example is that CXX_FLAGS sets -std=c++11, but with recent version of ICU (such as >= 77-1), -std=c++11 is not enough, passing -std=c++17 is needed. Unfortunately, it cannot be passed through CMAKE_CXX_FLAGS due to the aforementioned problem. This commit allows to resolve this by ensuring that CMAKE_CXX_FLAGS and CMAKE_C_FLAGS win over CXX_FLAGS/C_FLAGS. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ilt-in flags
CMakeLists.txt and booster/CMakeLists.txt define some flags in CXX_FLAGS, and then set CMAKE_CXX_FLAGS in a way that causes the flags in CXX_FLAGS to override the ones passed (for example on the command line through CMAKE_CXX_FLAGS). This prevents the user from overriding those compiler flags in CXX_FLAGS.
A specific example is that CXX_FLAGS sets -std=c++11, but with recent version of ICU (such as >= 77-1), -std=c++11 is not enough, passing -std=c++17 is needed. Unfortunately, it cannot be passed through CMAKE_CXX_FLAGS due to the aforementioned problem.
This commit allows to resolve this by ensuring that CMAKE_CXX_FLAGS and CMAKE_C_FLAGS win over CXX_FLAGS/C_FLAGS.