Updated timeShiftBufferDepth to be up to spec#10
Open
Wassup789 wants to merge 1 commit intoarut:masterfrom
Open
Updated timeShiftBufferDepth to be up to spec#10Wassup789 wants to merge 1 commit intoarut:masterfrom
Wassup789 wants to merge 1 commit intoarut:masterfrom
Conversation
Owner
|
@Wassup789 I did some research and came up with the current formula based on how dash.js treats the values. I will try your approach too. Thanks for your work. |
|
@Wassup789 , @arut , Hi 👋. this pull request seems has a typo. I've make a pre-built module docker images for this nginx module project, you can try here: https://github.com/nginx-with-docker/ngx_http_ts_module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As specified in MPEG-DASH spec, ISO 23009-1:2014, the
@timeShiftBufferDepthelement value should represent the time guaranteed to be available for viewing. This also enables VOD features as well if set properly.This commit changes the buffer depth to the maximum number of segments multiplied by the minimum buffer time of one segment since that length is guaranteed to exist.