fix: Bump compat floors for OrderedCollections and DataDeps#57
Merged
Conversation
Test against dependencies downgraded to their floor versions (mode: deps), on Julia lts, as its own workflow separate from CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 84.31% 88.46% +4.14%
==========================================
Files 5 5
Lines 51 52 +1
==========================================
+ Hits 43 46 +3
+ Misses 8 6 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OrderedCollections 1.1.0/1.2.0 (the resolved downgrade floor) don't
infer concrete key/value types when constructing an OrderedDict from
a generator, so LOCAL_EXAMPLE_DATA/REMOTE_EXAMPLE_DATA (and their
merge in load_example_data()) come out as OrderedDict{Any,Any} instead
of the documented OrderedDict{String,AbstractFileMetadata}. Fixed in
1.3.0, which infers types from the generator correctly. Reproduced
locally with the package's exact types before and after the bump.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
DataDeps 0.7.0-0.7.11 (the resolved downgrade floor) build their writable-path candidate list from Base.DEPOT_PATH and create the first candidate directory as a one-time side effect of top-level code run during precompilation. That side effect doesn't necessarily correspond to a real, writable directory in a differently-provisioned depot (as seen when CI restored cached compiled/dependency state), so every writable-path check failed with DataDeps.NoValidPathError. 0.7.12 moved this into __init__() (reruns every process start) and switched to a proper Scratch.jl-backed space. Verified locally that 0.7.12 resolves a valid save path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Patch release for the OrderedCollections and DataDeps compat floor fixes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sethaxen
changed the title
sethaxen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps two stale compat floors that fail under dependency downgrading, and cuts a patch release for the fix:
OrderedCollections:1→1.3. Older versions don't infer concrete key/value types when constructing anOrderedDictfrom a generator, soload_example_data()came back asOrderedDict{Any,Any}instead of the documentedOrderedDict{String,AbstractFileMetadata}.DataDeps:0.7→0.7.12. Older versions build their writable-path list fromBase.DEPOT_PATHand create the directory as a one-time side effect of precompilation, which doesn't reliably hold up once dependency/compiled state gets cached — causingNoValidPathError. 0.7.12 moved this into__init__()with a properScratch.jl-backed space.Also adds a separate
Downgrade.ymlworkflow (mode: deps, Julia lts) that caught both issues