feat: Add delete confirmation dialog for task deletion#725
Open
codevivekk wants to merge 1 commit into
Open
Conversation
- Add showConfirm state to track confirmation visibility - Implement handleDeleteClick, handleConfirmDelete, handleCancelDelete handlers - Add Escape key support to cancel confirmation - Display inline Confirm/Cancel buttons instead of Edit/Delete icons during confirmation - Prevent accidental task deletion with user confirmation requirement
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
State Management:
Added showConfirm state to track confirmation dialog visibility
Implemented three handlers: handleDeleteClick, handleConfirmDelete, and handleCancelDelete
User Experience Improvements:
Inline confirmation buttons replace Edit/Delete icons during confirmation phase
Escape key support to cancel the confirmation dialog
Prevents accidental task deletion by requiring explicit user confirmation
Implementation Details:
Added useEffect hook to listen for Escape key presses
Proper event listener cleanup on component unmount
Conditional rendering of action buttons based on confirmation state
Visual feedback with styled red "Confirm" and gray "Cancel" buttons
Files Changed
frontend/src/components/Task/TaskItem.jsx
🔗 Related Issue
Closes #24
🛠 Changes Made
✅ Checklist
🚀 Notes for Reviewers
Anything specific you want reviewed.