Fix/routine builder modal position#777
Open
Sonalis1299 wants to merge 3 commits into
Open
Conversation
Author
|
Hi @aryandas2911 ,I have completed the fix for the modal viewport positioning issue in the Routine Builder section and submitted the PR. Kindly review it when possible. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Fixed the modal positioning issue in the Routine Builder section where the “Create New Task” and “Save Routine” modals were appearing relative to the scrollable webpage instead of the visible viewport.
The issue was caused by the parent container animation class affecting the modal’s fixed positioning behavior.
🔗 Related Issue
Closes #732
🛠 Changes Made
📸 Screenshots
✅ Checklist
🚀 Notes for Reviewers
Tested the modals after scrolling the page vertically. Both “Create New Task” and “Save Routine” modals now remain centered relative to the viewport without requiring additional page scrolling.