fix: correct navbar active state for login and signup routes#778
Open
kanaklatwal wants to merge 1 commit into
Open
fix: correct navbar active state for login and signup routes#778kanaklatwal wants to merge 1 commit into
kanaklatwal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Fixed the navbar active state issue where the Signup button remained highlighted regardless of the current route.
The issue was caused because Login and Signup were using
Linkinstead ofNavLink, which prevented route-based active styling. Updated the implementation to use active route detection and corrected inactive styling behavior.🔗 Related Issue
Closes #768
🛠 Changes Made
LinkwithNavLinkfor Login and Signup buttonsisActive/loginand/signup📸 Screenshots (if applicable)
Verified:
/login→ only Login highlighted/signup→ only Signup highlighted✅ Checklist
🚀 Notes for Reviewers
Please review the active state behavior for authentication routes and confirm UI consistency.