Add lights to the vehicle example#461
Open
ClemensLinnhoff wants to merge 9 commits into
Open
Conversation
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
ClemensLinnhoff
temporarily deployed
to
github-pages
March 23, 2026 09:44 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
ClemensLinnhoff
temporarily deployed
to
github-pages
June 29, 2026 09:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ClemensLinnhoff
temporarily deployed
to
github-pages
June 29, 2026 09:20 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
ClemensLinnhoff
temporarily deployed
to
github-pages
June 29, 2026 09:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
…terials Signed-off-by: alexandros.siskos <alexandros.siskos@iccs.gr>
hansoleon
force-pushed
the
460-add-examples-for-vehicle-lights
branch
from
June 30, 2026 12:36
abce5ef to
b31be92
Compare
Member
|
MR to be reviewed by the group till the next meeting (09.07.2026) |
Signed-off-by: alexandros.siskos <alexandros.siskos@iccs.gr>
Signed-off-by: alexandros.siskos <alexandros.siskos@iccs.gr>
ClemensLinnhoff
commented
Jul 9, 2026
ClemensLinnhoff
commented
Jul 9, 2026
ClemensLinnhoff
commented
Jul 9, 2026
ClemensLinnhoff
commented
Jul 9, 2026
ClemensLinnhoff
commented
Jul 9, 2026
ClemensLinnhoff
commented
Jul 9, 2026
Comment on lines
+331
to
+347
| { | ||
| "node": "Window_R", | ||
| "thickness": 0.005 | ||
| }, | ||
| { | ||
| "node": "Window_FL", | ||
| "thickness": 0.005 | ||
| }, | ||
| { | ||
| "node": "Window_FR", | ||
| "thickness": 0.005 | ||
| }, | ||
| { | ||
| "node": "Window_F", | ||
| "thickness": 0.005 | ||
| } | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
When the content of the xoma file is finished, we should run an auto-formatter over the file. I think there are some indentations that are not correct.
ClemensLinnhoff
commented
Jul 9, 2026
… .bin file Signed-off-by: alexandros.siskos <alexandros.siskos@iccs.gr>
Signed-off-by: alexandros.siskos <alexandros.siskos@iccs.gr>
ClemensLinnhoff
commented
Jul 16, 2026
| }, | ||
| { | ||
| "assoc_node": "Grp_Light_High_Beam_Left_0", | ||
| "material_name": "Light_Head_Reflector_Left", |
Collaborator
Author
There was a problem hiding this comment.
For every light, there now are two emissive surfaces: lens and reflector. Since the lens is in front of the reflector, it would be enough, if just the lens was the emissive surface.
ClemensLinnhoff
temporarily deployed
to
github-pages
July 16, 2026 07:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Member
|
@hansoleon will change it again based on the comments and discussions. |
hansoleon
marked this pull request as ready for review
July 19, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Fixes #460
Checklist before requesting a review