Skip to content

Update e2e fixtures for size_bytes and pcidevice AER metrics#10

Open
anulika-asama wants to merge 1 commit into
masterfrom
diskstats/size_bytes-ci-fix
Open

Update e2e fixtures for size_bytes and pcidevice AER metrics#10
anulika-asama wants to merge 1 commit into
masterfrom
diskstats/size_bytes-ci-fix

Conversation

@anulika-asama

@anulika-asama anulika-asama commented Jun 23, 2026

Copy link
Copy Markdown

Refresh golden e2e outputs so test-e2e matches node_disk_info size_bytes and pcidevice AER counters emitted from fixture sysfs data.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added PCIe Advanced Error Reporting metrics to monitor correctable, fatal, and non-fatal errors across PCI devices and root ports.
    • Enhanced disk device metrics with comprehensive labeling, including size, serial number, model, and additional device attributes for improved visibility and monitoring.

Refresh golden e2e outputs so test-e2e matches node_disk_info size_bytes
and pcidevice AER counters emitted from fixture sysfs data.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40aa0320-aafc-43c5-b342-b30351f6ebaf

📥 Commits

Reviewing files that changed from the base of the PR and between 4d0ce53 and b6f840d.

📒 Files selected for processing (2)
  • collector/fixtures/e2e-64k-page-output.txt
  • collector/fixtures/e2e-output.txt

Walkthrough

Two e2e fixture files (e2e-output.txt and e2e-64k-page-output.txt) are updated: node_disk_info metric lines gain a size_bytes label across all device entries, and a new block of node_pcidevice_aer_* metrics is added covering correctable, fatal, non-fatal, and root-port total PCIe AER error counters.

Changes

E2E Fixture Updates

Layer / File(s) Summary
node_disk_info size_bytes label
collector/fixtures/e2e-64k-page-output.txt, collector/fixtures/e2e-output.txt
node_disk_info series are updated to include size_bytes (and in e2e-output.txt, additional fields like major, minor, model, path, revision, serial, and wwn) for all listed block devices (dm-*, mmcblk0*, nvme0n1, sda/sdb/sdc, sr0, vda).
PCIe AER metrics block
collector/fixtures/e2e-64k-page-output.txt, collector/fixtures/e2e-output.txt
A new fixture section adds node_pcidevice_aer_correctable_errors, node_pcidevice_aer_fatal_errors, node_pcidevice_aer_nonfatal_errors, and node_pcidevice_aer_rootport_total_errors series, each labeled by PCI bus, device, function, segment, and error_type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • asama-ai/node_exporter#9: Extends node_disk_info to include the size_bytes label in the diskstats collector and updates the associated e2e/golden fixture outputs, directly related to the size_bytes label changes in this PR.

Poem

🐇 Hop hop, the disks now show their size,
A size_bytes label, what a prize!
PCIe errors? We count them all—
Correctable, fatal, big and small.
The fixtures gleam with data true,
A rabbit's work is never through! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating e2e fixtures to include size_bytes label for disk metrics and adding pcidevice AER metrics.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch diskstats/size_bytes-ci-fix

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant