fix cascading livewire select inputs nulled after repainting#39
Open
bfiessinger wants to merge 1 commit intoasantibanez:masterfrom
Open
fix cascading livewire select inputs nulled after repainting#39bfiessinger wants to merge 1 commit intoasantibanez:masterfrom
bfiessinger wants to merge 1 commit intoasantibanez:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem:
As mentioned in #18 currently while executing the render method all livewire-select component values, which have dependencies, are nulled.
Assuming the following components the
car-brand-selectwould indeed show up with the right (visible) value, butcar-model-selectwould not only have no value, but it would also have no options (becausecar-brand-selectvalue is actuallynull)Solution:
I have added a new property to the livewire component, called
initValueEncoded, this value is set on mount the same as thevalueprop, but json encoded.why json? Refering to another pull request of mine (#37), it is mandatory that also an array of values can be submitted.
Inside the select.blade.json the
valueLivewire property can now be set during component initialization:(closes #18)