Refactor: Optimize proxy handling for improved performance#1
Open
Refactor: Optimize proxy handling for improved performance#1
Conversation
This commit introduces two key performance improvements to the gateway: 1. **Reusable Reverse Proxies**: Reverse proxy instances are now created once at server startup and reused for incoming requests. Previously, a new proxy instance was generated for each request, incurring significant overhead. This change modifies server initialization, request routing, and handler logic to use these persistent proxy instances. 2. **Configurable Debug Transport**: The `DebugTransport`, which logs outgoing request details for debugging, is now optional. It can be enabled/disabled via a `debugProxy` flag in the `global` section of the `configs/bff.yml` configuration file. By default, `debugProxy` is set to `false`, meaning the standard, more performant `http.DefaultTransport` is used. Enabling `DebugTransport` has a considerable performance impact and should only be used for debugging. These changes significantly reduce per-request overhead and allow for more fine-grained control over debugging features that impact performance. The README has also been updated to document the new `debugProxy` configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces two key performance improvements to the gateway:
Reusable Reverse Proxies: Reverse proxy instances are now created once at server startup and reused for incoming requests. Previously, a new proxy instance was generated for each request, incurring significant overhead. This change modifies server initialization, request routing, and handler logic to use these persistent proxy instances.
Configurable Debug Transport: The
DebugTransport, which logs outgoing request details for debugging, is now optional. It can be enabled/disabled via adebugProxyflag in theglobalsection of theconfigs/bff.ymlconfiguration file. By default,debugProxyis set tofalse, meaning the standard, more performanthttp.DefaultTransportis used. EnablingDebugTransporthas a considerable performance impact and should only be used for debugging.These changes significantly reduce per-request overhead and allow for more fine-grained control over debugging features that impact performance. The README has also been updated to document the new
debugProxyconfiguration.