added handling of Roman WCS information#4
Open
perrygreenfield wants to merge 1 commit into
Open
Conversation
braingram
reviewed
Jul 23, 2026
| node = af.tree | ||
| return extract_asdf_array(node, alist, af) | ||
| im = extract_asdf_array(node, alist, af) | ||
| if 'roman' in af.tree: |
There was a problem hiding this comment.
Maybe the follow-up mission-specific defaults can modify this logic so:
- for roman files look in roman.meta.wcs
- for other files, search for a gwcs instance
braingram
reviewed
Jul 23, 2026
| messagebox.showerror("ASDF Path Error", f"Specified ADSF path component '{value}' not in file") | ||
| return | ||
| gwcs = node | ||
| gwcs = tagged_tree_to_custom_tree(gwcs, ctx) |
There was a problem hiding this comment.
Is this tagged_tree_to_custom_tree needed? I would think this gwcs should be a WCS instance at this point.
braingram
reviewed
Jul 23, 2026
| """ | ||
| This currently only works for roman data | ||
| """ | ||
| import sys |
braingram
approved these changes
Jul 23, 2026
braingram
left a comment
braingram
left a comment
There was a problem hiding this comment.
LGTM. Left a few comments/nitpicks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create a FITS version of the Roman WCS using the SIP model, which currently is essentially identical to the GWCS version to floating point accuracy, and then transfers that SIP wcs model to ds9 when loading a Roman calibrated image.
If the changes are non-obvious, please explain how they work.
If this PR adds a new feature please include tests and documentation.
If this PR fixes an issue, please add closing keywords (eg 'fixes #XXX')
-->
No AI tools were used.
All AI usage must comply with our AI policy:
https://github.com/asdf-format/.github/blob/main/AI_POLICY.md
-->