add glob parsing to asdf-autoschemas directive#22
Open
CagtayFabry wants to merge 2 commits intoasdf-format:mainfrom
Open
add glob parsing to asdf-autoschemas directive#22CagtayFabry wants to merge 2 commits intoasdf-format:mainfrom
CagtayFabry wants to merge 2 commits intoasdf-format:mainfrom
Conversation
Contributor
|
I like the idea, but I think we'll want to use asdf library functions to list available schemas and perform the glob matching. That will be easier once asdf 2.8 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For larger collections of schemas I wanted to simplify doc creation and tried to get the
:glob:option to work withasdf-autoschemasbut got nowhere (would seem like an elegant solution).I managed to get it to work with some "glob-handling" (using
pathlib.Path.glob) additions to creating the schema files and doctree.So instead of specifying all files
.. asdf-autoschemas:: unit/unit-1.0.0 unit/defunit-1.0.0 unit/quantity-1.1.0the following would get extended to all yaml schemas in
unit/.. asdf-autoschemas:: unit/*Is this something you would like to see added in
sphinx-asdf?I'm leaving this PR in case anyone wants to give it a try, code would certainly need some cleanup