Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ console-subscriber = "0.4"
uuid = { version = "1.18.0", features = ["std", "v4", "v7", "zerocopy"] }
rand = "0.8"
socket2 = "0.5"
smallvec = { version = "1.13" }

[build-dependencies]
capnpc = "0.21.2"
Expand Down
62 changes: 58 additions & 4 deletions src/storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -731,14 +731,16 @@ fn build_lease_entry_message(
let mut lease_entry_builder = lease_entry.init_root::<protocol::lease_entry::Builder>();
lease_entry_builder.set_expiry_ts_secs(expiry_ts_secs);
lease_entry_builder.set_expiry_ts_index_key(expiry_index_key_bytes);
// Write ids unsorted first.
// Collect borrowed id slices. For small batches, avoid heap alloc by using SmallVec.
let n = polled_items.len();
// Stable sort without copying id bytes: collect borrowed slices, sort stably, then write
let mut borrowed: Vec<&[u8]> = Vec::with_capacity(n);
use smallvec::SmallVec;
let mut borrowed: SmallVec<[&[u8]; 32]> = SmallVec::with_capacity(n.min(32));
for item in polled_items.iter() {
borrowed.push(item.get()?.get_id()?);
}
borrowed.sort(); // stable
if n > 1 {
borrowed.sort();
}
let mut out_ids = lease_entry_builder.init_ids(n as u32);
for (i, id) in borrowed.into_iter().enumerate() {
out_ids.set(i as u32, id);
Expand Down Expand Up @@ -1150,6 +1152,58 @@ mod tests {
Ok(())
}

#[test]
fn build_lease_entry_message_skips_sort_for_single() -> Result<()> {
// Create a single polled item
let mut msg = Builder::new_default();
let mut pi = msg.init_root::<protocol::polled_item::Builder>();
pi.set_id(b"z");
pi.set_contents(b"c");
let typed = msg.into_typed();
let owned: PolledItemOwnedReader = typed.into_reader();

// Build lease entry and read back via serialization
let lease_msg = build_lease_entry_message(123, b"k", &[owned])?;
let mut buf = Vec::new();
serialize::write_message(&mut buf, &lease_msg)?;
let msg =
serialize::read_message_from_flat_slice(&mut &buf[..], message::ReaderOptions::new())?;
let reader = msg.get_root::<protocol::lease_entry::Reader>()?;
let ids = reader.get_ids()?;
assert_eq!(ids.len(), 1);
assert_eq!(ids.get(0)?, b"z");
Ok(())
}

#[test]
fn build_lease_entry_message_sorts_multiple_ids() -> Result<()> {
// Two items out of order by id
let mut m1 = Builder::new_default();
let mut p1 = m1.init_root::<protocol::polled_item::Builder>();
p1.set_id(b"b");
p1.set_contents(b"x");
let o1: PolledItemOwnedReader = m1.into_typed().into_reader();

let mut m2 = Builder::new_default();
let mut p2 = m2.init_root::<protocol::polled_item::Builder>();
p2.set_id(b"a");
p2.set_contents(b"y");
let o2: PolledItemOwnedReader = m2.into_typed().into_reader();

// Build lease entry with unsorted inputs [b, a]
let lease_msg = build_lease_entry_message(1, b"k", &[o1, o2])?;
let mut buf = Vec::new();
serialize::write_message(&mut buf, &lease_msg)?;
let msg =
serialize::read_message_from_flat_slice(&mut &buf[..], message::ReaderOptions::new())?;
let reader = msg.get_root::<protocol::lease_entry::Reader>()?;
let ids = reader.get_ids()?;
assert_eq!(ids.len(), 2);
assert_eq!(ids.get(0)?, b"a");
assert_eq!(ids.get(1)?, b"b");
Ok(())
}

#[test]
fn poll_moves_multiple_items_and_updates_indexes()
-> std::result::Result<(), Box<dyn std::error::Error>> {
Expand Down