Fix flaky lease expiry test - #111
Merged
Merged
Conversation
Co-authored-by: miles.frankel <miles.frankel@gmail.com>
|
Cursor Agent can help with this pull request. Just |
asg0451
marked this pull request as ready for review
September 14, 2025 22:27
|
Criterion benchmarks delta (ms; lower is better)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a guard to the lease sweeper to prevent expiring extended leases due to stale expiry index entries.
The
expire_due_leasesfunction could incorrectly expire a lease that had been extended. This happened if a stale expiry index entry (pointing to an old, past expiry time) was processed before the lease's actual entry (which had been updated with a new, future expiry). The guard checks the lease's true expiry time and, if it's in the future, only deletes the stale index key, resolving the race condition and fixing the flakyextend_existing_lease_updates_expiry_indextest.