Skip to content

Simplify RetriedStorage verbosity and overhead#112

Open
asg0451 wants to merge 2 commits into
masterfrom
cursor/simplify-retriedstorage-verbosity-and-overhead-20a1
Open

Simplify RetriedStorage verbosity and overhead#112
asg0451 wants to merge 2 commits into
masterfrom
cursor/simplify-retriedstorage-verbosity-and-overhead-20a1

Conversation

@asg0451

@asg0451 asg0451 commented Sep 15, 2025

Copy link
Copy Markdown
Owner

Refactor RetriedStorage methods to reduce verbosity and duplication by introducing generic retry helpers.


Open in Cursor Open in Web

Co-authored-by: miles.frankel <miles.frankel@gmail.com>
@cursor

cursor Bot commented Sep 15, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Co-authored-by: miles.frankel <miles.frankel@gmail.com>
@github-actions

github-actions Bot commented Sep 15, 2025

Copy link
Copy Markdown

Criterion benchmarks delta (ms; lower is better)

Benchmark PR (ms) Master (ms) Δ (ms) Δ (%)
e2e_rpc/rpc_add_batch_200 0.624 0.619 0.005 +0.8%
e2e_rpc/rpc_poll_batch_200 51.190 49.311 1.879 +3.8%
e2e_rpc/rpc_remove_each_200 26.168 24.697 1.471 +6.0%
e2e_rpc/rpc_stress_like_p2_a2_items_200 1180.926 1067.424 113.502 +10.6%
storage_add/add_available_500 8.157 8.157 0.000 +0.0%
storage_poll/get_next_available_entries_500 10.135 10.254 -0.119 -1.2%
storage_remove/remove_in_progress_500 20.259 20.562 -0.303 -1.5%

@asg0451
asg0451 marked this pull request as ready for review September 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants