Skip to content

optimize alloc #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asg0451 merged 1 commit into from
Sep 17, 2025
Merged

optimize alloc #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,11 @@ impl Storage {

// Stage 3: decode, build response items, and move entries to in_progress within the txn.
let mut polled_items = Vec::with_capacity(fetched_values.len().min(n));
let mut lease_entry_bs = Vec::with_capacity(
(LEASE_NUM_BYTES
+ (InProgressKey::PREFIX.len() + LIKELY_ID_NUM_BYTES) * locked_pairs.len())
.min(1024),
);
for (i, (idx_key, main_key)) in locked_pairs.into_iter().enumerate() {
if polled_items.len() >= n {
break;
Expand Down Expand Up @@ -411,7 +416,7 @@ impl Storage {
lease_expiry_index_key.as_bytes(),
&polled_items,
)?;
let mut lease_entry_bs = Vec::with_capacity(lease_entry.size_in_words() * 8); // TODO: avoid allocation
lease_entry_bs.clear();
serialize::write_message(&mut lease_entry_bs, &lease_entry)?;

// Write the lease entry and its expiry index
Expand Down Expand Up @@ -755,7 +760,9 @@ impl Storage {
}

/// uuidv7 bytes
type Lease = [u8; 16];
const LEASE_NUM_BYTES: usize = 16;
const LIKELY_ID_NUM_BYTES: usize = 16; // IDs are uuidv7s even though it's not clear here. shouldnt be used for correctness
type Lease = [u8; LEASE_NUM_BYTES];

type PolledItemOwnedReader =
TypedReader<capnp::message::Builder<message::HeapAllocator>, protocol::polled_item::Owned>;
Expand Down Expand Up @@ -1426,7 +1433,7 @@ mod tests {
assert_eq!(entries.len(), 1);

// attempt removal with a different lease (non-existent)
let wrong_lease: [u8; 16] = Uuid::now_v7().into_bytes();
let wrong_lease: Lease = Uuid::now_v7().into_bytes();
assert_ne!(lease, wrong_lease);
let removed = storage.remove_in_progress_item(b"only", &wrong_lease)?;
assert!(!removed);
Expand Down